Fix Bot Mention Trigger Silently Discarded by Queue Worker Due to Raw Event Name Mismatch
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Aptitud para principiantes
- 67/100
- Tipo de issue
- Error
- Claridad
- Bien especificado
- Estado de actividad
- Activo
- Stack tecnológico
- github, node.js, typescript
- Área
- backend-api-design, devops
Línea de trabajo
Read packages/core/src/review/resolve-job.ts and trace how it loads webhook_deliveries; compare that path with normalization in packages/provider-github/src/webhook.ts and delivery creation in packages/api/src/routes/webhook.ts. Start with the tests around resolveQueuedJob and add coverage for an issue_comment delivery and a closed pull_request delivery. Done means mention reviews and PR-close label cleanup run, existing auto-triggered reviews still work, and the listed typecheck, test, and lint commands pass.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Summary
Mention-triggered reviews (e.g. @codra review posted as a PR comment) are silently dropped before they ever reach the review worker. The pipeline queues the message, but the worker discards it immediately because it checks for a normalized event name that was never stored.
Root Cause
The webhook handler in packages/api/src/routes/webhook.ts reads the raw GitHub header x-github-event (value: "issue_comment") and stores it in the webhook_deliveries table as-is.
When the queue worker calls resolveQueuedJob in packages/core/src/review/resolve-job.ts, it loads the delivery and checks:
if (eventName !== "change_request" && eventName !== "comment") {
logger.info(`Queue message ignored: unsupported webhook event ${eventName}`);
return null;
}
Since delivery.event_name is "issue_comment" (raw GitHub header), not "comment" (the normalized name), the check fails and the message is thrown away. Mention-triggered reviews never execute.
The same mismatch applies to pull_request to change_request for PR-close label cleanup. Any job that takes the fallback path through the delivery lookup (without an inline jobId or payload on the queue message) can be affected.
Affected Files
packages/api/src/routes/webhook.ts- stores raweventNamein delivery and passes it raw to the queue message (L274-278)packages/core/src/review/resolve-job.ts- checks normalized names against raw stored names (L42-50)packages/provider-github/src/webhook.ts-normalizeGitHubWebhookcorrectly maps"issue_comment"to"comment", but is never called on the worker path
Proposed Fix
In resolveQueuedJob, after loading the delivery record, normalize eventName before checking:
// After loading delivery:
const normalized = env.webhooks.normalizePayload(delivery.event_name, delivery.payload);
if (normalized) {
eventName = normalized.eventName; // "comment" or "change_request"
payload = normalized.payload;
} else {
eventName = delivery.event_name;
payload = delivery.payload as WebhookPayload;
}
Alternatively (and more robustly), store the normalized event name in webhook_deliveries at insertion time in the webhook route, so the queue always receives the canonical name regardless of which path it takes.
Done When
-
@codra reviewcomments on a PR trigger a review job correctly - PR-close label cleanup runs for
pull_requestclosed events - Existing auto-triggered PR reviews (
opened,synchronize, etc.) continue to work - Tests cover the mention trigger path end-to-end through
resolveQueuedJob - Any backend changes work in both Cloudflare Workers and Node/Docker
-
npm run typecheck,npm test, andnpm run lintall pass
Before Closing
-
npm run typecheck,npm test, andnpm run lintall pass - Any backend changes work in both Cloudflare Workers and Node/Docker
- Tests cover the changed behavior in each affected runtime
- Lenguaje dominante
- TypeScript
- Estrellas
- 125
- Forks
- 23
- Merge medio
- 2 d 13 h
- PR fusionados (30 d)
- 12
Preparar el entorno
- Incluye un Dockerfile o un archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de devarshishimpi/codra
-
bug good first issue
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100
devarshishimpi/codra#178 ·
Los mantenedores suelen responder en 1 día
-
bug good first issue
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
devarshishimpi/codra#176 ·
Los mantenedores suelen responder en 1 día
-
enhancement good first issue
Dificultad 4/5 3-5 días Aptitud para principiantes 48/100
devarshishimpi/codra#186 ·
Los mantenedores suelen responder en 1 día
-
enhancement good first issue
Dificultad 4/5 3-5 días Aptitud para principiantes 55/100
devarshishimpi/codra#185 ·
Los mantenedores suelen responder en 1 día
-
enhancement good first issue
Dificultad 4/5 3-5 días Aptitud para principiantes 58/100
devarshishimpi/codra#184 ·
Los mantenedores suelen responder en 1 día
Todos los issues de devarshishimpi/codra
Issues similares
-
Dificultad 1/5 1-3 horas Aptitud para principiantes 83/100
gofish-graphics/gofish-graphics#1384 ·
Los mantenedores suelen responder en 1 día
-
adapter bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 83/100
Olanetsoft/agent-lookout#353 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
vicharanashala/vibe#1542 ·
Los mantenedores suelen responder en 1 día
-
bug chore P2 size:XS
Dificultad 2/5 1-3 horas Aptitud para principiantes 77/100
josephfung/curia#2666 ·
Los mantenedores suelen responder en 1 día
-
area: batch
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
inabagumi/shinju-date#7294 ·
Los mantenedores suelen responder en 1 día