Add Playwright Tests for Core Dashboard Flows

Aperta
#185 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
55/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
playwright, typescript
Ambito
testing

Direzione di ricerca

Start by reading the sibling issue for Playwright setup and the dashboard routes and components for /, /dashboard, /jobs, /repos, and /stats; the payload does not name their files. Then add E2E coverage for the listed flows, using seeded data and a deterministic OAuth stub where needed. Done means all seven flows pass repeatedly, no test uses hardcoded waits, and typecheck, test, and lint pass.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

enhancement good first issue

Goal

Implement Playwright E2E tests for the core dashboard user journeys.

Background

With Playwright configured (see sibling sub-issue), the dashboard flows need actual test coverage. This sub-issue implements the tests; CI integration is a sibling sub-issue.

This sub-issue is part of the parent issue: Playwright E2E test suite for core dashboard flows.

Flows to Cover

Flow Description
Landing & Auth Visit /, expect login page; simulate GitHub OAuth callback; verify redirect to /dashboard
Dashboard Overview Verify KPI cards render, time range selector works, recent reviews table loads
Jobs List Navigate to /jobs; search by PR title; filter by status; paginate
Job Detail Open a seeded job; verify stepper, findings list (by file / by severity), and diff viewer tab render
Repository Settings Navigate to /repos; toggle a repo enabled/paused; open model settings modal
Stats Page Navigate to /stats; verify charts render without errors
Theme Toggle Toggle between dark/light mode; verify preference persists on reload

Implementation Guidance

  • Use Playwright's built-in locators (getByRole, getByTestId) over CSS selectors for resilience
  • Add data-testid attributes to key dashboard components where needed
  • Never rely on hardcoded waits (page.waitForTimeout); use waitForSelector, waitForResponse, or Playwright's auto-waiting
  • Auth flow may need a mocked or stubbed GitHub OAuth callback for deterministic tests

Done When

  • At least the Landing/Auth, Dashboard Overview, Jobs List, Job Detail, and Repository Settings flows have passing tests
  • Stats page and Theme toggle flows have passing tests
  • No test uses hardcoded waits
  • Tests are deterministic across repeated local runs
  • npm run typecheck, npm test, and npm run lint all pass
Lingua principale
TypeScript
Stelle
125
Fork
23
Merge medio
2g 13h
PR unite (30g)
12

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di devarshishimpi/codra

Tutte le issue di devarshishimpi/codra

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.