Limrun Android: `fill` inserts at the cursor instead of replacing the field's text
I maintainer di solito rispondono entro 1 giorno
Valutazione
- Difficoltà
- 3/5
- Tempo stimato
- 1-2 giorni
- Idoneità per principianti
- 62/100
- Tipo di issue
- Bug
- Chiarezza
- Specificata chiaramente
- Stato di attività
- Attiva
- Stack tecnologico
- android, typescript
- Ambito
- mobile
Direzione di ricerca
Start in the Android fill path where agent-device returns after the provider-native provider.text call, since that call skips the adb clear, verify and retry steps (KEYCODE_MOVE_END and KEYCODE_DEL). The Limrun instance client's setText and pressKey calls are the relevant entry points. Done means fill on a field with existing text leaves exactly the new value, and a mismatch is reported rather than passing silently. Reproduce with the Settings search field commands in the issue.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Summary
On a Limrun Android instance, fill does not replace the existing contents of a text field. The new text is inserted wherever the tap leaves the cursor, so filling a field that already has a value produces a concatenation of the old and new text. The help text says fill <target> <text> replaces, and that is what happens on local emulators.
Environment
- agent-device: 0.21.15, and the same code path is present in 0.21.24 (latest at the time of writing)
- Provider: Limrun, Android instance (
agent-device connect limrun --platform android) - Keyboard on the instance:
com.android.inputmethod.latin(the agent-device test IME is not active) - App: the system Settings app (any
EditTextreproduces it)
Steps to reproduce
agent-device connect limrun --platform android --run-id fill-repro --session repro
agent-device open settings --platform android --session repro
agent-device snapshot -i --platform android --session repro # find "Search Settings"
agent-device click @e2 --platform android --session repro # opens the search field
agent-device fill @e7 "[email protected]" --platform android --session repro
agent-device fill @e7 "[email protected]" --platform android --session repro
agent-device snapshot -i --platform android --session repro
Expected
After the second fill, the field contains:
[email protected]
Actual
The second fill taps the field center, which puts the cursor inside the existing value, and inserts the text there:
[email protected][email protected]
Both fill calls exit successfully. A caller that does not re-read the field carries on with the wrong value.
Cause
On Android, fill first checks whether the device provider supplies its own text entry. Limrun does (provider.text → the Limrun instance client's setText({ x, y }, text)), so agent-device returns after that call. It never reaches the Android path that clears the field (KEYCODE_MOVE_END + KEYCODE_DEL), verifies the result and retries, or uses the test IME.
Calling the Limrun Android instance client directly on the same instance shows that setText never replaces:
| Call | Result |
|---|---|
setText({ x, y }, text) (what agent-device sends) |
inserted at the cursor |
setText({ selector: { focused: true } }, text) |
inserted at the cursor |
setText(undefined, text) |
inserted at the cursor |
setText({ selector: { focused: true } }, '') |
rejected: text is required |
So with the provider-native path there is currently no way to clear the field before typing.
Workaround that worked
Selecting all and deleting with hardware key events before setText, through the same Limrun instance client:
await client.pressKey('a', ['ctrl']);
await client.pressKey('del');
await client.setText(undefined, text);
This left the field holding exactly the requested text in 3 of 3 runs. The select and delete took about 350 ms together; setText took about 1 s.
Suggested fix
For a Limrun Android fill, clear the focused field before the provider-native setText (for example with the Ctrl+A / Delete key events above), then run the existing verification so a mismatch is reported instead of passing silently. Alternatively, route Limrun Android fill through the existing adb clear/verify/retry path or the test IME.
Possibly related (not reproduced)
In one run, a fill into a field that had just taken focus from another field lost its first character (jane… arrived as ane…). I could not reproduce it on a single field in 4 attempts, so it is mentioned only in case it shares the cause.
- Lingua principale
- TypeScript
- Stelle
- 4.9k
- Fork
- 328
- Merge medio
- 12h 18m
- PR unite (30g)
- 538
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Nessun modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di callstack/agent-device
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 88/100
callstack/agent-device#3353 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
callstack/agent-device#1869 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 3/5 1-2 giorni Idoneità per principianti 45/100
callstack/agent-device#3392 ·
I maintainer di solito rispondono entro 1 giorno
-
settings permission --app writes a display name as the bundle id instead of resolving itForse già presa @thymikee l’ha presa 1 giorno fa. Aperta
Difficoltà 3/5 1-2 giorni Idoneità per principianti 22/100
callstack/agent-device#3384 ·
I maintainer di solito rispondono entro 1 giorno
-
iOS: a canceled request releases the session lock while its runner command still runs on the deviceForse già presa @thymikee l’ha presa 1 giorno fa. Aperta
Difficoltà 4/5 3-5 giorni Idoneità per principianti 22/100
callstack/agent-device#3383 ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di callstack/agent-device
Issue simili
-
Remove the landing pageApertaby: ai-assisted frontend good-for: new-member spike
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
Northeastern-Electric-Racing/Argos#847 ·
I maintainer di solito rispondono entro 4 giorni
-
Difficoltà 1/5 1-3 ore Idoneità per principianti 84/100
SignalK/freeboard-sk#990 ·
I maintainer di solito rispondono entro 1 giorno
-
[missing-inheritance] audit review (1 preset)Forse già presa @github-actions l’ha presa oggi. Aperta
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 82/100
osmberlin/tagging-schema-browser#363 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
enhancement
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
Albert-Weasker/niubigeo#205 ·
I maintainer di solito rispondono entro 1 giorno
-
area/frontend area/v2 kind/bug priority/needs-triage
Difficoltà 2/5 1-3 ore Idoneità per principianti 70/100
kubeflow/notebooks#1498 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno