macOS builds without an Xcode project end up with a broken code signature (Apple.Core edits the .app after Unity signs it)

Aperta
#132 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
55/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
csharp, macos, unity

Direzione di ricerca

Start with AppleBuild.OnPostProcessBuild and the Info.plist, frameworks, and entitlements steps described in the issue; check how the build target and Xcode project setting are detected. Reproduce with a plain macOS .app and run codesign --verify --deep --strict --verbose=2 on it. Done means the resulting app verifies successfully and follows the issue’s expected handling of settings, bundles, and signing.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug Plugin-in - Core

Describe the bug
When building for macOS with "Create Xcode Project" off (a plain .app, e.g. for Steam), AppleBuild.OnPostProcessBuild changes the .app after Unity has already signed it, and nothing signs it again:

  • Automate Info.plist rewrites Contents/Info.plist (adds ITSAppUsesNonExemptEncryption, plus LSMinimumSystemVersion when Apple Build Settings has a minimum macOS version).
  • The frameworks step copies AppleCoreNativeMac.bundle, GameKitWrapper.bundle and their .dSYM folders into Contents/PlugIns.
  • Automate Entitlements writes <Product Name>.entitlements next to the .app, where nothing uses it.

In one of our Steam builds, the Info.plist hash stored in the main executable's ad-hoc signature no longer matches Contents/Info.plist, and _CodeSignature/CodeResources lists every bundle in Contents/PlugIns except AppleCoreNativeMac.bundle and GameKitWrapper.bundle.

To Reproduce

  1. Project with Apple.Core and Apple.GameKit, Automate Info.plist and Automate Entitlements on (the defaults).
  2. Build for macOS with Create Xcode Project off.
  3. Run codesign --verify --deep --strict --verbose=2 on the built .app. It fails.

Expected behavior
The .app Unity produced stays validly signed. The Info.plist keys and the entitlements file are App Store settings a plain .app can't use, so skip them in this case (or apply them before Unity signs). Keep .dSYM folders out of Contents/PlugIns, and re-sign the .app after copying the plug-in bundles into it.

Environment
Unity 6000.6, macOS Standalone (Apple Silicon), Create Xcode Project off. Seen with Apple.Core 3.2.0 / Apple.GameKit 4.0.1; the code is unchanged in 3.3.0 / 4.1.0 (27.0, ffe6174) and on main (96e4a04).

Additional context
What we patch into our embedded copy:

bool isPlainMacApp = buildTarget == BuildTarget.StandaloneOSX && !AppleNativeLibraryUtility.IsXcodeProjectGeneratedForMac;
// skip the Info.plist and entitlements regions when isPlainMacApp, then after the finalize step:
if (isPlainMacApp)
{
    // runs /usr/bin/codesign --force --sign - "<app>" (ad-hoc, the way Unity signed it)
    ResignPlainMacApp(generatedProjectPath);
}
Lingua principale
C#
Stelle
1k
Fork
257
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di apple/unityplugins

Tutte le issue di apple/unityplugins

Issue simili

Altre issue su C#

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.