Why is all Editor build-processing code gated to UNITY_EDITOR_OSX?
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 55/100
- Tipo di issue
- Bug
- Chiarezza
- Abbastanza chiara
- Stato di attività
- Attiva
- Ambito
- build-system, game-dev
Direzione di ricerca
Start with the UNITY_EDITOR_OSX guards in Apple.Core/Editor/AppleBuildProfile.cs, AppleBuildStep.cs, AppleBuild.cs, AppleCoreBuildStep.cs, AppleSecurityBuildStep.cs, and the other plug-in Editor files; compare them with Apple.BackgroundAssets/Editor/BuildStep.cs. Reproduce the Linux batchmode BuildPipeline.BuildPlayer compilation failure, then verify the agreed guard scope against the later macOS xcodebuild step; done means Linux export compiles and produces the Xcode project without breaking the macOS archive path.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Why is all Editor build-processing code gated to UNITY_EDITOR_OSX? (it blocks splitting the whole build to something like Unity export to happen on Linux machine and the Xcode build on macOS)
Context: the pipeline
Build split in two stages, on two different machines.
- Unity export, on a Linux machine — this is the step that opens the project in batchmode
and callsBuildPipeline.BuildPlayerfor iOS, producing the.xcodeproj. - Xcode build, on a macOS machine —
xcodebuild archive/export on the project produced
in step 1.
This is a common CI shape for people that build for multiple platforms (iOS + Android, etc.) from
one Unity project and want to keep the compute-heavy Linux fleet doing as much of the shared work
as possible, only handing macOS machines the part that strictly needs Xcode.
What broke
Every Editor build-processing file I've looked at, across every plug-in in this repo, is wrapped
in the identical condition:
#if (UNITY_EDITOR_OSX && (UNITY_IOS || UNITY_TVOS || UNITY_STANDALONE_OSX || UNITY_VISIONOS))
UNITY_EDITOR_OSX is defined based on the OS the Editor process is running on, not the build
target. Since my export runs on Linux, this symbol is false there, for every file, in every
plug-in, simultaneously — this isn't per-file behavior, it's one symbol shared by the whole compile.
Two consequences I hit:
Apple.BackgroundAssets/Editor/BuildStep.csis the one file in the whole repo missing this
guard (every sibling file —AppleBuildProfile.cs,AppleBuildStep.cs,AppleBuild.cs,
AppleCoreBuildStep.cs,AppleSecurityBuildStep.cs,AppleUserManagementBuildStep.cs, and the
equivalent files in Accessibility, CoreHaptics, GameController, GameKit, StoreKit — all have it).
BecauseAppleBuildProfilecompiles out to nothing on Linux, butBuildStep.csreferences it
unconditionally, Editor script compilation hard-fails there:
CS0246: The type or namespace name 'AppleBuildProfile' could not be found.
Why I don't think this needs to be macOS-only
I read through Apple.Core's Editor code specifically looking for something that would force it
to run on a macOS host, and didn't find one:
AppleBuildProfile(Apple.Core/Editor/AppleBuildProfile.cs) is a plainScriptableObject:
a dictionary, some strings,AssetDatabasecalls. No OS-specific API anywhere in it.AppleBuild.OnPostProcessBuild(Apple.Core/Editor/AppleBuild.cs) reads/writesInfo.plistand
entitlements files, opens the.pbxprojviaPBXProject, and builds a shell-script string that
gets written into a Run Script build phase. I grepped this file forProcess.Start,
ProcessStartInfo,DllImport,xcrun,codesign,lipo— anything that would mean this C#
code itself invokes a native macOS tool during export — and found nothing. The only appearance
ofcodesignin the file is as a literal string embedded in the generated build-phase script
(around lines 398/409/455/466), meant to run later, underxcodebuilditself. That anyway
must happen on a macOS machines regardless of this guard; it isn't a reason the export step
needs to be on macOS too.- More generally:
UnityEditor.iOS.Xcode(PBXProject,PlistDocument) is Unity's own managed,
cross-platform library for editing.pbxproj/.plistfiles as structured text. Building an iOS
Xcode project from a non-macOS Editor host and archiving it separately on macOS is a supported,
fairly common CI pattern in the Unity ecosystem specifically because these APIs don't require
Xcode or macOS to run — only the laterxcodebuildstep does.
Given all of that, I couldn't find a point in this code path where it actually needs the Editor
process itself to be on macOS, as opposed to needing a Mac only for the parts that were already
guaranteed to run there anyway (the later xcodebuild/archive step, and the earlier one-time
build.py step that produced the native libraries in the first place).
Where the guard came from
Introduced in commit b4002b66f01999e4b66f609974826aaf21d59eff ("Replacing Unity's native
library management", PR #27), which moved native-library selection/embedding from Unity's own
per-platform plugin importer into Apple.Core's own system.
Environment
- Unity: 6000.4.0f1
- Setup: Unity export on Linux, Xcode archive on macOS machines
Question
Is UNITY_EDITOR_OSX a hard technical requirement for this code, or a deliberate scope decision (i.e. "we only support this when the Editor host itself is macOS")? If it's the latter, would you consider narrowing the guard to only where it's actually load-bearing — e.g. around the native library embedding/signing calls specifically — so the rest of the Info.plist/entitlements/build-step machinery can run on a non-Mac Editor host, even if native library embedding itself still needs a Mac?
- Lingua principale
- C#
- Stelle
- 988
- Fork
- 251
- Merge medio
- 2g 22h
- PR unite (30g)
- 11
Preparare l'ambiente
Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di apple/unityplugins
-
bug
Difficoltà 4/5 3-5 giorni Idoneità per principianti 35/100
apple/unityplugins#124 ·
I maintainer di solito rispondono entro 1 giorno
-
Arguments for Push Message localisation in SendExchange do not seem to workForse di nuovo libera @ryzngard l’ha presa 121 giorni fa e non c’è nessuna pull request aperta. Apertabug Plug-in - GameKit
apple/unityplugins#98 · 2 commenti · 1 assegnatario ·
I maintainer di solito rispondono entro 1 giorno
-
Use internal when exposing low-level types like IntPtrForse di nuovo libera @ryzngard l’ha presa 147 giorni fa e non c’è nessuna pull request aperta. Apertabug
apple/unityplugins#97 · 1 assegnatario ·
I maintainer di solito rispondono entro 1 giorno
-
Provide pre-compiled .unitypackage files for the Apple Unity PluginsForse di nuovo libera @ryzngard l’ha presa 147 giorni fa e non c’è nessuna pull request aperta. Apertafeature request
apple/unityplugins#94 · 3 commenti · 8 reazioni · 1 assegnatario ·
I maintainer di solito rispondono entro 1 giorno
-
feature request Plug-in - GameKit
Difficoltà 5/5 Più di una settimana Idoneità per principianti 45/100
apple/unityplugins#93 · 1 reazione ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di apple/unityplugins
Issue simili
-
bug P3
Difficoltà 2/5 1-3 ore Idoneità per principianti 88/100
nightscout/nocturne#1908 ·
I maintainer di solito rispondono entro 1 giorno
-
bug documentation Needs: Triage :mag:
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
-
WPF: each page's `Title` overwrites the window title, and returning to a page does not restore itAperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
I maintainer di solito rispondono entro 1 giorno
-
agentic-workflows area/Docs partner/agentic-workflows
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 82/100
I maintainer di solito rispondono entro 1 giorno
-
bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
jamesmontemagno/tiny-clips#378 · 2 commenti ·
I maintainer di solito rispondono entro 1 giorno