Node SDK: send accepts malformed user headers that fail during polling

Aperta
#4,750 3 commenti 0 reazioni 1 assegnatario Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@Subham-KRLX ci sta già lavorando.

Dal 4/11/2026.

  • #4764 di @Subham-KRLX — aperta

Valutazione

Questa issue non è ancora stata valutata.

Descrizione

bug good first issue javascript
Bug description

The Node SDK accepts malformed user headers when sending messages, but polling those messages fails to decode them.

Confirmed cases:

  • Empty raw header value.
  • String value longer than 255 bytes.
  • Int128 value containing only one byte instead of 16.
  • Empty string key.

Each send receives a confirmation at offset 0. Polling then fails with “user headers of the message at offset 0 do not decode.” A valid string header sends and polls successfully.

The encoder should reject these invalid headers before sending. Confirmed against a real server using SDK and server revision 7b053f4cbf635d03ba187123a42c0157ac554587.

Related fixes #4481 (Go) and #4670 (HTTP) do not cover the Node encoder. I would like to contribute a regression test first and discuss the fix approach.

Affected area / component

Node.js SDK

Deployment

Docker (DockerHub image)

Versions

SDK and server revision: 7b053f4cbf635d03ba187123a42c0157ac554587

Server image: apache/iggy:edge

Image digest: sha256:3dba2cd7b16e0362112ae248507b4a7b2eb27593332c6421386011fb1795975d

Hardware / environment

macOS, Node.js v24.4.1, fresh single-node Iggy server in Docker. Tested using the upstream Node SDK over TCP, with isolated container storage.

Sample code
const headers = [{
  key: HeaderKeyFactory.String('key'),
  value: HeaderValue.Raw(Buffer.alloc(0))
}];

const result = await client.message.send({
  streamId,
  topicId,
  partition: Partitioning.PartitionId(0),
  messages: [{ id: 1n, payload: 'repro', headers }]
});
// Send succeeds with a confirmation at offset 0.

await client.message.poll({
  streamId,
  topicId,
  consumer: Consumer.Single,
  partitionId: 0,
  pollingStrategy: PollingStrategy.First,
  count: 1,
  autocommit: false
});
// Fails to decode the stored message's headers.
Logs

valid: SEND CONFIRMED offset=0
valid: POLL SUCCEEDED
empty-value: SEND CONFIRMED offset=0
empty-value: POLL FAILED user headers of the message at offset 0 do not decode; cause=Invalid header value length: 0, must be between 1 and 255

Iggy server config

Fresh single-node server with development credentials.

IGGY_HTTP_ADDRESS=0.0.0.0:3000
IGGY_TCP_ADDRESS=0.0.0.0:38090
IGGY_NODE_ADVERTISED_ADDRESS=localhost

TCP port 38090 was published to localhost. No custom persistence settings.

Reproduction
  1. Start a fresh Iggy server and connect using the Node SDK.
  2. Create a stream and a topic with one partition.
  3. Send a message containing a string header key and an empty raw header value, as shown above.
  4. The send succeeds and confirms offset 0.
  5. Poll the topic from the first offset.
  6. Polling fails because the header value length is 0.

Also reproduced with:

  • HeaderValue.String('a'.repeat(256))
  • HeaderValue.Int128(Buffer.from([1]))
  • HeaderKeyFactory.String('') with a nonempty value

A normal nonempty string key and value send and poll successfully.

Contribution
  • I'm willing to submit a pull request to fix this bug
Good first issue
  • I think this could be a good first issue for a new contributor
Lingua principale
Rust
Stelle
5.2k
Fork
502
Merge medio
2g 21h
PR unite (30g)
159

Preparare l'ambiente

Apri in Codespaces

Avvia il container di sviluppo del progetto nel browser, con il tuo account GitHub.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di apache/iggy

Tutte le issue di apache/iggy

Issue simili

Altre issue su Rust

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.