Node SDK: send accepts malformed user headers that fail during polling

Abierto
#4,750 3 comentarios 0 reacciones 1 asignado Ver en GitHub

Los mantenedores suelen responder en 1 día

@Subham-KRLX ya está trabajando en esto.

Desde el 4/11/2026.

  • #4764 de @Subham-KRLX — abierto

Evaluación

Este issue todavía no se ha evaluado.

Descripción

bug good first issue javascript
Bug description

The Node SDK accepts malformed user headers when sending messages, but polling those messages fails to decode them.

Confirmed cases:

  • Empty raw header value.
  • String value longer than 255 bytes.
  • Int128 value containing only one byte instead of 16.
  • Empty string key.

Each send receives a confirmation at offset 0. Polling then fails with “user headers of the message at offset 0 do not decode.” A valid string header sends and polls successfully.

The encoder should reject these invalid headers before sending. Confirmed against a real server using SDK and server revision 7b053f4cbf635d03ba187123a42c0157ac554587.

Related fixes #4481 (Go) and #4670 (HTTP) do not cover the Node encoder. I would like to contribute a regression test first and discuss the fix approach.

Affected area / component

Node.js SDK

Deployment

Docker (DockerHub image)

Versions

SDK and server revision: 7b053f4cbf635d03ba187123a42c0157ac554587

Server image: apache/iggy:edge

Image digest: sha256:3dba2cd7b16e0362112ae248507b4a7b2eb27593332c6421386011fb1795975d

Hardware / environment

macOS, Node.js v24.4.1, fresh single-node Iggy server in Docker. Tested using the upstream Node SDK over TCP, with isolated container storage.

Sample code
const headers = [{
  key: HeaderKeyFactory.String('key'),
  value: HeaderValue.Raw(Buffer.alloc(0))
}];

const result = await client.message.send({
  streamId,
  topicId,
  partition: Partitioning.PartitionId(0),
  messages: [{ id: 1n, payload: 'repro', headers }]
});
// Send succeeds with a confirmation at offset 0.

await client.message.poll({
  streamId,
  topicId,
  consumer: Consumer.Single,
  partitionId: 0,
  pollingStrategy: PollingStrategy.First,
  count: 1,
  autocommit: false
});
// Fails to decode the stored message's headers.
Logs

valid: SEND CONFIRMED offset=0
valid: POLL SUCCEEDED
empty-value: SEND CONFIRMED offset=0
empty-value: POLL FAILED user headers of the message at offset 0 do not decode; cause=Invalid header value length: 0, must be between 1 and 255

Iggy server config

Fresh single-node server with development credentials.

IGGY_HTTP_ADDRESS=0.0.0.0:3000
IGGY_TCP_ADDRESS=0.0.0.0:38090
IGGY_NODE_ADVERTISED_ADDRESS=localhost

TCP port 38090 was published to localhost. No custom persistence settings.

Reproduction
  1. Start a fresh Iggy server and connect using the Node SDK.
  2. Create a stream and a topic with one partition.
  3. Send a message containing a string header key and an empty raw header value, as shown above.
  4. The send succeeds and confirms offset 0.
  5. Poll the topic from the first offset.
  6. Polling fails because the header value length is 0.

Also reproduced with:

  • HeaderValue.String('a'.repeat(256))
  • HeaderValue.Int128(Buffer.from([1]))
  • HeaderKeyFactory.String('') with a nonempty value

A normal nonempty string key and value send and poll successfully.

Contribution
  • I'm willing to submit a pull request to fix this bug
Good first issue
  • I think this could be a good first issue for a new contributor
Lenguaje dominante
Rust
Estrellas
5.2k
Forks
516
Merge medio
2 d 21 h
PR fusionados (30 d)
159

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de apache/iggy

Todos los issues de apache/iggy

Issues similares

Más issues de Rust

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.