Comet Native Executors: report each stage's Comet block metrics to Ballista

Aperta
  • Qualcosa non va?
#7,465 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 2 giorni

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
Più di una settimana
Idoneità per principianti
22/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
rust, scala, spark
Ambito
data-engineering, distributed-systems

Direzione di ricerca

The block is CometFragmentExec, which reports no metrics; its metrics() and the plan it builds inside execute are where the change starts. Ballista's stage metric aggregation, which sums elapsed_compute over the stage's operators and counts input rows from plan leaves, is the other side. Done means a two-stage query shows non-zero compute time and correct input rows for the range stage in the scheduler event log.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

enhancement requires-triage
What is the problem the feature request solves?

Ballista takes a task's metrics from the operators of its stage plan. On a Comet Native Executor cluster, a stage's plan is a shuffle writer over a CometFragmentExec, whose children are the stage's partition descriptor and its shuffle readers. CometFragmentExec reports no metrics, and the Comet operators run in a plan it builds inside execute, which Ballista never sees. So in the scheduler's event logs (COMET_SCHEDULER_EVENT_LOG_DIR, #7420) and stage summaries:

  • A task's compute time (elapsed_compute_nanos) covers only its shuffle readers' poll time, and is 0 for a stage with no shuffle input.
  • Input rows count only the rows a stage reads from other stages, so a stage that reads files or makes its own rows logs 0.
  • The plan shows each block only as CometFragmentExec: block=N bytes.

In a two-stage query, a range stage hash-shuffled into a stage that reads it, the range stage's task logged 0 input rows and 0 compute time, and the reading stage's task logged 1000 input rows and 3.3 ms, the shuffle reader's poll time. Output rows and task times are right.

Describe the potential solution

CometFragmentExec could keep the plan it builds for each partition and report the block's metrics from metrics(): its operators' elapsed_compute, and the output rows of its file scans and other leaves. Ballista sums elapsed_compute over every operator of the stage, so the block's figure shouldn't count the time its inputs spend in the shuffle readers, which report their own. Ballista counts a stage's input rows from the plan's leaves, and CometFragmentExec isn't one, so rows read from files need another way in, whether a leaf that reports them or a change to how Ballista counts input rows.

#7373 needs the block's per-operator metrics too, to fill in the Spark UI.

Additional context

Found in the review of #7420: https://github.com/apache/datafusion-comet/pull/7420#discussion_r4460104688

Part of #7288.

Willingness to contribute

Yes. I can contribute this feature independently.

Lingua principale
Scala
Stelle
1.3k
Fork
414
Merge medio
3g 5h
PR unite (30g)
210

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di apache/datafusion-comet

Tutte le issue di apache/datafusion-comet

Issue simili

Altre issue su Scala

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.