Comet Native Executors: report each stage's Comet block metrics to Ballista

オープン
  • 何か問題がありますか？
#7,465 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 2 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
1週間以上
初心者へのやさしさ
22/100
issue の種類
機能追加
明瞭さ
おおむね明確
活発さ
活発
技術スタック
rust, scala, spark
領域
data-engineering, distributed-systems

調査の方向性

The block is CometFragmentExec, which reports no metrics; its metrics() and the plan it builds inside execute are where the change starts. Ballista's stage metric aggregation, which sums elapsed_compute over the stage's operators and counts input rows from plan leaves, is the other side. Done means a two-stage query shows non-zero compute time and correct input rows for the range stage in the scheduler event log.

索引モデルが issue の本文から書いたものです。

説明

enhancement requires-triage
What is the problem the feature request solves?

Ballista takes a task's metrics from the operators of its stage plan. On a Comet Native Executor cluster, a stage's plan is a shuffle writer over a CometFragmentExec, whose children are the stage's partition descriptor and its shuffle readers. CometFragmentExec reports no metrics, and the Comet operators run in a plan it builds inside execute, which Ballista never sees. So in the scheduler's event logs (COMET_SCHEDULER_EVENT_LOG_DIR, #7420) and stage summaries:

  • A task's compute time (elapsed_compute_nanos) covers only its shuffle readers' poll time, and is 0 for a stage with no shuffle input.
  • Input rows count only the rows a stage reads from other stages, so a stage that reads files or makes its own rows logs 0.
  • The plan shows each block only as CometFragmentExec: block=N bytes.

In a two-stage query, a range stage hash-shuffled into a stage that reads it, the range stage's task logged 0 input rows and 0 compute time, and the reading stage's task logged 1000 input rows and 3.3 ms, the shuffle reader's poll time. Output rows and task times are right.

Describe the potential solution

CometFragmentExec could keep the plan it builds for each partition and report the block's metrics from metrics(): its operators' elapsed_compute, and the output rows of its file scans and other leaves. Ballista sums elapsed_compute over every operator of the stage, so the block's figure shouldn't count the time its inputs spend in the shuffle readers, which report their own. Ballista counts a stage's input rows from the plan's leaves, and CometFragmentExec isn't one, so rows read from files need another way in, whether a leaf that reports them or a change to how Ballista counts input rows.

#7373 needs the block's per-operator metrics too, to fill in the Spark UI.

Additional context

Found in the review of #7420: https://github.com/apache/datafusion-comet/pull/7420#discussion_r4460104688

Part of #7288.

Willingness to contribute

Yes. I can contribute this feature independently.

主要言語
Scala
スター
1.3k
フォーク
414
平均マージ
3日 5時間
マージ済み PR（30日）
210

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

apache/datafusion-comet のほかの issue

apache/datafusion-comet の issue をすべて見る

似ている issue

Scala の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。