Stacked bars: round the whole column (scope: 'stack')

Aperta
#202 0 commenti 4 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
35/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
typescript

Direzione di ricerca

Start with the barY mark's radius handling and SceneRect cornerRadii, then trace how stack and group layouts determine each segment's geometry. The issue describes the required cases: thin exposed segments, negative and diverging stacks, barX, reversed scales, grouped columns, motion, and per-segment hit areas and focus. Done means the stack keeps a consistent rounded outline as its height and segment values change; the issue does not identify specific files or tests.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Description

A stacked column should read as one rounded bar. With the per-rect corner radii from #28, we round the outer end of the outermost segment and keep the inner seams square. That works as long as the outermost segment is at least as tall as the radius.

When the outermost segment is thin, the column loses its rounded end. The radius is scaled to fit the rect, the same way CSS does it. So a 2px segment gets 2px corners, and the larger segment below it stays square. Real data hits this all the time: in a revenue-per-category stack, the smallest category on top is often only one or two pixels tall in most columns.

Current behavior

barY(segments, {
  x: 'week',
  y: 'revenue',
  z: 'category',
  layout: stack({ order }),
  // Per row: top-left/top-right on the outermost visible segment,
  // bottom corners on the innermost one, 0 on the seams.
  radius: stackedRadius,
})
  • Outermost segment ≥ radius: the column is rounded.
  • Outermost segment < radius: its corners shrink to its height, and the column looks square.

radius only receives the row, not pixel geometry. Even when it gets a pixel-aware resolver, a SceneRect with cornerRadii can't draw the right shape:

  • The thin top segment would need a horizontal strip cut from the rounded column, with curved left and right edges.
  • The segment below would need the rest of the curve.

Group clip is a plain ChartBounds rectangle, so we can't clip a column's segments to one rounded rect either.

Desired behavior

An option that rounds the whole stack instead of each segment. Every segment is drawn as its part of one rounded column, so the column's outline is always the same rounded rect, however the total is split.

  • A segment that lies entirely within radius px of an exposed end gets part of the curve.
  • Inner seams stay straight.
  • It works for negative and diverging stacks (each exposed end is rounded), for barX, and for reversed scales, like the { end } form.
  • It works with group() + stack (paired columns) as well as a plain stack.
  • Motion: segments animate with the stack, and the curve follows the changing column height.
  • Hit areas and focus stay per segment.

Possible API shapes, building on the existing forms:

radius: { end: 6, scope: 'stack' }   // round the exposed end(s) of the stack
radius: { all: 6, scope: 'stack' }   // also round the baseline end

Another option is a rounded group clip (SceneGroup.clip accepting corner radii), which a custom mark could use per column. A scope option on the bar mark would be the more natural API, though.

Prior art

Highcharts has exactly this: borderRadius: { radius, scope: 'stack' | 'point', where: 'end' | 'all' }. From its API docs:

The value stack means the rounding will apply to the full stack, so that only points close to the top or bottom will receive rounding.

Internally it computes the rounding against the stack's total box and not against each point's box (borderRadius.scope === 'stack' in the column series).

Our workaround today

We resolve a corner tuple per row, from the same rows the mark draws and in stack order. It skips zero and null segments so a missing category doesn't hold the rounding away from the visible end. That covers seams and missing values, but it can't fix the thin-end case above. The only alternatives we found change the data (a minimum segment height) or depend on wrapping barY's scene output, which we'd rather not maintain.

Version: @tanstack/charts 1.0.0, SVG renderer with motion().

Related: #28

Lingua principale
TypeScript
Stelle
870
Fork
57
Merge medio
11h 58m
PR unite (30g)
18

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di TanStack/charts

Tutte le issue di TanStack/charts

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.