[Perf] `motion()`: every update resolves each element's timing context with DOM queries and scans of all points

Aperta
#271 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
48/100
Tipo di issue
Refactoring
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
d3, javascript, typescript

Direzione di ricerca

Start in packages/charts-core/src/motion.ts, especially addUpdateTrack, createPresentationTracks, elementTimingContext, and motionPointForKey; compare the current scene walk with the proposal to build a key-to-point map and per-mark point counts once. Trace how the reconcile walk can supply each leaf's group, role, and peers, then run the motion tests and benchmark the supplied motion() repro against static SVG. Done when repeated per-element DOM queries and full-scene scans are removed and update cost scales closer to element count.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Version: @tanstack/charts 1.5.0 (b236dae).

Under motion(), an update's cost grows faster than its element count. One keyed rect mark, only y values changing, median synchronous host.update in headless Chromium 153:

Bars motion() Static SVG renderer
100 3.5 ms 0.9 ms
200 7.6 ms 1.3 ms
400 19.4 ms 2.1 ms
800 60.7 ms 4.0 ms

Compiling the scene is about 1 ms at 800 bars. A CPU profile at 400 bars puts 68% of host.update inside elementTimingContext, 26% in motionPointForKey alone.

Why

addUpdateTrack resolves a timing context for every retained element (motion.ts:2198), and createPresentationTracks again for every point that moved (motion.ts:3368-3371). Each one starts from the leaf:

A mark with n elements does about n² string comparisons for each update.

Repro

Bundle for a browser and run await bench().

import { defineChart, rect } from '@tanstack/charts'
import { motion } from '@tanstack/charts/motion'
import { mountChartRenderer } from '@tanstack/charts/renderer'
import { scaleLinear } from '@tanstack/charts/scales/linear'
import { createSvgChartRenderer } from '@tanstack/charts/svg/renderer'

const definition = (count: number, step: number) =>
  defineChart({
    marks: [
      rect(
        Array.from({ length: count }, (_, k) => ({ key: `r${k}`, x1: k - 0.4, x2: k + 0.4, y2: 40 + 30 * Math.sin(step + k) })),
        { x1: 'x1', x2: 'x2', y1: () => 0, y2: 'y2', key: 'key' },
      ),
    ],
    scales: { x: { scale: scaleLinear().domain([-0.5, count - 0.5]) }, y: { scale: scaleLinear().domain([0, 80]) } },
    pointer: false,
  })

async function measure(count: number, animated: boolean) {
  const renderer = animated ? motion({ initial: false }) : createSvgChartRenderer()
  const options = (step: number) => ({ definition: definition(count, step), renderer, width: 900, height: 300, ariaLabel: 'cost' })
  const host = mountChartRenderer(document.body.appendChild(document.createElement('div')), options(0))
  const times: number[] = []
  for (let step = 1; step <= 60; step++) {
    await new Promise(requestAnimationFrame)
    const next = options(step)
    const started = performance.now()
    host.update(next)
    times.push(performance.now() - started)
  }
  host.destroy()
  return times.sort((a, b) => a - b)[30]?.toFixed(1)
}

window.bench = async () => {
  await measure(100, true) // warm up
  for (const count of [100, 200, 400, 800])
    console.log(`${count} bars: motion() ${await measure(count, true)} ms, static SVG ${await measure(count, false)} ms`)
}
Proposal

Build a key-to-point map and a point count for each markId once for a scene, and find the owning group, role and peers on the way down the reconcile walk, not from each leaf.

Related: #186, #188, #201, PR #268.

Lingua principale
TypeScript
Stelle
870
Fork
57
Merge medio
11h 58m
PR unite (30g)
18

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di TanStack/charts

Tutte le issue di TanStack/charts

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.