Server shutdown can exit mid-join, leaving a paused-and-resumed recording cut to its first segment
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 3/5
- Tempo stimato
- 1-2 giorni
- Idoneità per principianti
- 68/100
- Tipo di issue
- Bug
- Chiarezza
- Specificata chiaramente
- Stato di attività
- Attiva
- Stack tecnologico
- node.js, typescript
Direzione di ricerca
Start with src/utils/sessions.ts and trace how classifyOrphan and reapOrphans handle dead recordings with parts; read the related stop and join flow in src/utils/lifecycle.ts and src/utils/pause.ts. Add or adjust a test for a dead-pid recording with parts, then run npm test. Done means an interrupted segmented recording is joined on startup or reported with an error that lists its parts.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Summary
On client disconnect, shutdown calls stopAll with a 10 s cap and then process.exit. A stop can need longer: up to 8 s for the graceful quit, up to 10 s in whenFinalized, then the stream-copy join of every segment. When the cap wins, the process exits with the join unfinished and the registry still says "recording". On the next start, classifyOrphan turns that record into a plain "stopped" with no error. Only "paused" records get the "parts were not joined" error.
Where
src/index.ts:132, 144(shutdown cap, exit)src/utils/lifecycle.ts:251-272, 322, 349-354(stopAll,runStop)src/utils/pause.ts:288(finishSegmentsjoin)src/utils/sessions.ts:134-140(classifyOrphan)
Impact
A user who paused and resumed a long recording and then closed the client gets an outputPath holding only the first segment, with the rest left in <output>.parts/, and no error anywhere. The webcam alignment step is affected the same way.
Steps to reproduce
- Record a few minutes, pause, resume, and record several more minutes (large segments make the join slow).
- Close the client so the server shuts down.
- After a restart,
get_sessionshowsstoppedwith no error, the output is the first segment's length, and<output>.parts/part-001.mp4remains.
Suggested fix
In reapOrphans, flag a dead "recording" record that has segments.parts.length > 0 (or a webcam) the same way paused ones are flagged, or better, re-run joinSegments for it at boot. Optionally persist an interim {status: "stopping"} so the next boot knows the join did not finish.
Acceptance criteria
- A segmented recording whose join was interrupted is either joined at the next start or reported with an error that lists the parts.
- Test for
classifyOrphan/reapOrphanswith a dead-pid recording record that has parts.
Getting started
- Relevant files:
src/utils/sessions.ts,src/utils/lifecycle.ts,src/utils/pause.ts - How to run tests:
npm test
Filed by repo-audit/full-audit at b9b94fa. Severity: medium. Effort: M. audit-key: reliability|src/utils/lifecycle.ts|stopAll
- Lingua principale
- TypeScript
- Stelle
- 1
- Fork
- 4
- Merge medio
- 14h 8m
- PR unite (30g)
- 48
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di TMHSDigital/screencast-mcp
-
effort: small good first issue priority: medium testing
Difficoltà 2/5 1-3 ore Idoneità per principianti 84/100
TMHSDigital/screencast-mcp#351 ·
I maintainer di solito rispondono entro 1 giorno
-
bug effort: small priority: medium
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
TMHSDigital/screencast-mcp#344 ·
I maintainer di solito rispondono entro 1 giorno
-
bug effort: small good first issue priority: medium
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
TMHSDigital/screencast-mcp#343 ·
I maintainer di solito rispondono entro 1 giorno
-
effort: medium help wanted priority: medium testing
Difficoltà 3/5 1-2 giorni Idoneità per principianti 76/100
TMHSDigital/screencast-mcp#350 ·
I maintainer di solito rispondono entro 1 giorno
-
effort: medium priority: medium testing
Difficoltà 4/5 1-2 giorni Idoneità per principianti 70/100
TMHSDigital/screencast-mcp#349 ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di TMHSDigital/screencast-mcp
Issue simili
-
clawsweeper:fix-shape-clear clawsweeper:queueable-fix clawsweeper:source-repro impact:ux-friction issue-rating: 🦞 diamond lobster no-stale P3
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
openclaw/openclaw#200365 · 1 commento · 1 reazione ·
I maintainer di solito rispondono entro 1 giorno
-
area-templates triage:bot-seen triage:needs-human
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
microsoft/aspire#22356 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
Archiving an agent that is not loaded keeps its old updatedAtForse già presa @luoph l’ha presa oggi. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
I maintainer di solito rispondono entro 1 giorno
-
content triage
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 88/100
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
I maintainer di solito rispondono entro 1 giorno