Server shutdown can exit mid-join, leaving a paused-and-resumed recording cut to its first segment

Ouverte
#345 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
68/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
node.js, typescript
Domaine
backend, devtools

Piste de recherche

Start with src/utils/sessions.ts and trace how classifyOrphan and reapOrphans handle dead recordings with parts; read the related stop and join flow in src/utils/lifecycle.ts and src/utils/pause.ts. Add or adjust a test for a dead-pid recording with parts, then run npm test. Done means an interrupted segmented recording is joined on startup or reported with an error that lists its parts.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

effort: medium priority: medium reliability

Summary

On client disconnect, shutdown calls stopAll with a 10 s cap and then process.exit. A stop can need longer: up to 8 s for the graceful quit, up to 10 s in whenFinalized, then the stream-copy join of every segment. When the cap wins, the process exits with the join unfinished and the registry still says "recording". On the next start, classifyOrphan turns that record into a plain "stopped" with no error. Only "paused" records get the "parts were not joined" error.

Where

  • src/index.ts:132, 144 (shutdown cap, exit)
  • src/utils/lifecycle.ts:251-272, 322, 349-354 (stopAll, runStop)
  • src/utils/pause.ts:288 (finishSegments join)
  • src/utils/sessions.ts:134-140 (classifyOrphan)

Impact

A user who paused and resumed a long recording and then closed the client gets an outputPath holding only the first segment, with the rest left in <output>.parts/, and no error anywhere. The webcam alignment step is affected the same way.

Steps to reproduce

  1. Record a few minutes, pause, resume, and record several more minutes (large segments make the join slow).
  2. Close the client so the server shuts down.
  3. After a restart, get_session shows stopped with no error, the output is the first segment's length, and <output>.parts/part-001.mp4 remains.

Suggested fix

In reapOrphans, flag a dead "recording" record that has segments.parts.length > 0 (or a webcam) the same way paused ones are flagged, or better, re-run joinSegments for it at boot. Optionally persist an interim {status: "stopping"} so the next boot knows the join did not finish.

Acceptance criteria

  • A segmented recording whose join was interrupted is either joined at the next start or reported with an error that lists the parts.
  • Test for classifyOrphan/reapOrphans with a dead-pid recording record that has parts.

Getting started

  • Relevant files: src/utils/sessions.ts, src/utils/lifecycle.ts, src/utils/pause.ts
  • How to run tests: npm test

Filed by repo-audit/full-audit at b9b94fa. Severity: medium. Effort: M. audit-key: reliability|src/utils/lifecycle.ts|stopAll

Langage dominant
TypeScript
Étoiles
1
Forks
4
Merge moyen
14 h 8 min
PR mergées (30 j)
48

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de TMHSDigital/screencast-mcp

Toutes les issues de TMHSDigital/screencast-mcp

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.