Tests for wait_for_change handler validation, the wgc path and text mode

Aperta
#350 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
76/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
typescript
Ambito
testing

Direzione di ricerca

Read src/tools/waitForChange.ts and the existing mocking pattern in startRecording.test.ts:45-54; run npm test to see the current test setup. Add handler tests for the validation, WGC, text mode, cleanup, keep, and cancellation cases listed in the issue, using mocked capture helpers. Done when those cases pass without relying on a live screen.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

effort: medium help wanted priority: medium testing

Summary

The loops behind wait_for_change are unit-tested, but the handler that wires them runs only in the capture smoke and the opt-in local test. toolLayer.test.ts skips it because it polls a live screen. Local coverage: 32.4% lines / 26.5% branches.

Where

  • src/tools/waitForChange.ts:108-110 (mode/text mismatch), :118 (wgc needs one window), :138-147 (wgc size probe and temp-dir cleanup), :184-203 (text mode, gone), :219-223 (finally cleanup), :239-252 (keep/returnImage/cancelled)
  • src/__tests__/integration/toolLayer.test.ts:45

Impact

wait_for_change is the recommended replacement for sleeps in agent flows. A wrong elapsedSec, a leaked screencast-wait-* temp dir, or a broken text mode would not be caught on any CI leg except by the flaky Windows smoke.

Suggested fix

Handler tests with runFfmpegFrames, captureStill, readFrames and resolveCaptureTarget mocked (vi.mock, as in startRecording.test.ts:45-54):

  • mode "text" without text, and text without mode: isError with the "Use text with mode" message.
  • backend "wgc" with target "full": isError "watches one window".
  • wgc first still probes to 0x0: isError, and no screencast-wait-* dir left in tmpdir.
  • mode text, OCR finds the text: outcome "met" with matches; with gone: true: gone: true.
  • grab throws mid-loop: isError, stream aborted, work dir removed.
  • keep:true: screenshotPath exists; keep:false: the temp shot is removed; cancelled: no image.

Getting started

  • Relevant files: src/tools/waitForChange.ts, src/utils/waitLoop.ts
  • How to run tests: npm test

Filed by repo-audit/full-audit at b9b94fa. Severity: medium. Effort: M. audit-key: testing|src/tools/waitForChange.ts|register

Lingua principale
TypeScript
Stelle
1
Fork
4
Merge medio
14h 8m
PR unite (30g)
48

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di TMHSDigital/screencast-mcp

Tutte le issue di TMHSDigital/screencast-mcp

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.