Household net income leaves out armed forces independence payment

Aperta
  • Qualcosa non va?
#2,872 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 2 giorni

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
65/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
python
Ambito
backend, databases

Direzione di ricerca

Read household_benefits.py and its HOUSEHOLD_BENEFIT_VARIABLES definition, then find the existing tests for household_benefits and add a case showing AFIP is counted. Check whether issue #2809 has moved the list into programs.yaml; if so, add the AFIP entry beside afcs there. Before changing HBAI_HOUSEHOLD_NET_INCOME_ADDS in hbai_household_net_income.py, establish whether DWP's Households Below Average Income counts AFIP. Done when the household benefit total includes AFIP and the test passes.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

household_benefits adds afcs but not armed_forces_independence_payment, so household net and gross income leave out armed forces independence payment (AFIP). afcs adds only afcs_reported, the FRS's benefit code 8, and AFIP's documentation says "It is not part of afcs."

On main at 5c7744144:

  • HOUSEHOLD_BENEFIT_VARIABLES in household_benefits.py lists afcs and no AFIP, and household_net_income, household_net_income_ahc and household_gross_income each add household_benefits.
  • HBAI_HOUSEHOLD_NET_INCOME_ADDS in hbai_household_net_income.py lists afcs, pip and dla, and no AFIP.
  • The other readers of AFIP, such as the benefit cap exemptions and the severe disability premium, test receipt. The Childcare Offer for Wales counts the amount in its own income test, and none of them adds AFIP to household income.

policyengine-uk-data doesn't set armed_forces_independence_payment, so the gap shows in households a user enters with AFIP rather than in survey aggregates.

Fix

Add armed_forces_independence_payment beside afcs in HOUSEHOLD_BENEFIT_VARIABLES, with a test that household_benefits counts it. #2809 moves that list into programs.yaml and flags afcs there as budget: benefit. If #2809 lands first, add an AFIP entry beside it. Before adding AFIP to HBAI_HOUSEHOLD_NET_INCOME_ADDS, check whether DWP's Households Below Average Income counts it.

Lingua principale
Python
Stelle
53
Fork
34
Merge medio
3g 8h
PR unite (30g)
322

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di PolicyEngine/policyengine-uk

Tutte le issue di PolicyEngine/policyengine-uk

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.