Household net income leaves out armed forces independence payment

Abierto
  • ¿Algo no está bien?
#2,872 0 comentarios 0 reacciones 1 asignado Ver en GitHub

Los mantenedores suelen responder en 2 días

@juaristi22 ya está trabajando en esto.

Desde el 5/11/2026.

  • #2880 de @juaristi22 — abierto

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
65/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
python
Área
backend, databases

Línea de trabajo

Read household_benefits.py and its HOUSEHOLD_BENEFIT_VARIABLES definition, then find the existing tests for household_benefits and add a case showing AFIP is counted. Check whether issue #2809 has moved the list into programs.yaml; if so, add the AFIP entry beside afcs there. Before changing HBAI_HOUSEHOLD_NET_INCOME_ADDS in hbai_household_net_income.py, establish whether DWP's Households Below Average Income counts AFIP. Done when the household benefit total includes AFIP and the test passes.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

household_benefits adds afcs but not armed_forces_independence_payment, so household net and gross income leave out armed forces independence payment (AFIP). afcs adds only afcs_reported, the FRS's benefit code 8, and AFIP's documentation says "It is not part of afcs."

On main at 5c7744144:

  • HOUSEHOLD_BENEFIT_VARIABLES in household_benefits.py lists afcs and no AFIP, and household_net_income, household_net_income_ahc and household_gross_income each add household_benefits.
  • HBAI_HOUSEHOLD_NET_INCOME_ADDS in hbai_household_net_income.py lists afcs, pip and dla, and no AFIP.
  • The other readers of AFIP, such as the benefit cap exemptions and the severe disability premium, test receipt. The Childcare Offer for Wales counts the amount in its own income test, and none of them adds AFIP to household income.

policyengine-uk-data doesn't set armed_forces_independence_payment, so the gap shows in households a user enters with AFIP rather than in survey aggregates.

Fix

Add armed_forces_independence_payment beside afcs in HOUSEHOLD_BENEFIT_VARIABLES, with a test that household_benefits counts it. #2809 moves that list into programs.yaml and flags afcs there as budget: benefit. If #2809 lands first, add an AFIP entry beside it. Before adding AFIP to HBAI_HOUSEHOLD_NET_INCOME_ADDS, check whether DWP's Households Below Average Income counts it.

Lenguaje dominante
Python
Estrellas
53
Forks
34
Merge medio
3 d 10 h
PR fusionados (30 d)
321

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de PolicyEngine/policyengine-uk

Todos los issues de PolicyEngine/policyengine-uk

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.