make 3.81 check: a != or ::= assignment inside an eval call passes, and the two makes differ on it silently

Aperta
#2,472 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
53/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
c, python
Ambito
testing, tooling

Direzione di ricerca

Read tools/make381_number_sign_check.py and its sign_in_eval logic, then use tools/make381_oracle.py to check the three eval cases listed in the issue against GNU Make 3.81. Run make precheck with planted lines and the stated controls to verify which cases are refused. Done means the header states coverage and exclusions in one sentence, with each sentence tied to its case.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area:gates found-by:critic kind:gate-defect

Found by the blind review of #2469, outside that change's cases. The check of #2456 refuses a != or ::= assignment on the lines it judges; a bare call is not a judged line, so the same assignment written inside an eval call passes:

$(eval X != printf a)

GNU Make 3.81: exit 0, X=[]. GNU Make 4.3: exit 0, X=[a]. tools/make381_number_sign_check.py: no finding.

$(eval X ::= a)

GNU Make 3.81: exit 0, X=[], and no variable X. GNU Make 4.3: exit 0, X=[a]. The check: no finding.

Both makes exit 0 on both, so nothing on the macOS runners fails by itself: the hazard is the one #2456 names, one step further in.

The check already reads the text of an eval call for a number sign (sign_in_eval), so the place to look exists. What is not decided here is how far it goes: a form in the literal text of an eval call is a small step; a form in a variable or a define that an eval call expands is the "text that exists only after expansion" the header names as not covered.

Done when

  • Decided on this issue, by cases answered by a real GNU Make 3.81 (tools/make381_oracle.py): which of these the check refuses, and which the header names as not covered: a form in the literal text of an eval call; in a define's body that an eval call expands by name; in a $(call ...) argument that reaches an eval.
  • What is refused is shown red first on a planted line through make precheck; controls stay clean: a != inside a $(shell ...) argument inside an eval call, and a form after a doubled dollar ($$(...)) reference in a define.
  • The header says in one sentence what is and is not covered, and each sentence has its case.

— Claude DevBox

Lingua principale
C
Stelle
3
Fork
7
Merge medio
3h 28m
PR unite (30g)
270

Preparare l'ambiente

Apri in Codespaces

Avvia il container di sviluppo del progetto nel browser, con il tuo account GitHub.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di InauguralSystems/EigenScript

Tutte le issue di InauguralSystems/EigenScript

Issue simili

Altre issue su C

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.