make 3.81 check: a != or ::= assignment inside an eval call passes, and the two makes differ on it silently

Abierto
#2,472 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
53/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
c, python
Área
testing, tooling

Línea de trabajo

Read tools/make381_number_sign_check.py and its sign_in_eval logic, then use tools/make381_oracle.py to check the three eval cases listed in the issue against GNU Make 3.81. Run make precheck with planted lines and the stated controls to verify which cases are refused. Done means the header states coverage and exclusions in one sentence, with each sentence tied to its case.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area:gates found-by:critic kind:gate-defect

Found by the blind review of #2469, outside that change's cases. The check of #2456 refuses a != or ::= assignment on the lines it judges; a bare call is not a judged line, so the same assignment written inside an eval call passes:

$(eval X != printf a)

GNU Make 3.81: exit 0, X=[]. GNU Make 4.3: exit 0, X=[a]. tools/make381_number_sign_check.py: no finding.

$(eval X ::= a)

GNU Make 3.81: exit 0, X=[], and no variable X. GNU Make 4.3: exit 0, X=[a]. The check: no finding.

Both makes exit 0 on both, so nothing on the macOS runners fails by itself: the hazard is the one #2456 names, one step further in.

The check already reads the text of an eval call for a number sign (sign_in_eval), so the place to look exists. What is not decided here is how far it goes: a form in the literal text of an eval call is a small step; a form in a variable or a define that an eval call expands is the "text that exists only after expansion" the header names as not covered.

Done when

  • Decided on this issue, by cases answered by a real GNU Make 3.81 (tools/make381_oracle.py): which of these the check refuses, and which the header names as not covered: a form in the literal text of an eval call; in a define's body that an eval call expands by name; in a $(call ...) argument that reaches an eval.
  • What is refused is shown red first on a planted line through make precheck; controls stay clean: a != inside a $(shell ...) argument inside an eval call, and a form after a doubled dollar ($$(...)) reference in a define.
  • The header says in one sentence what is and is not covered, and each sentence has its case.

— Claude DevBox

Lenguaje dominante
C
Estrellas
3
Forks
7
Merge medio
3 h 28 min
PR fusionados (30 d)
270

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de InauguralSystems/EigenScript

Todos los issues de InauguralSystems/EigenScript

Issues similares

Más issues de C

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.