make 3.81 check: a != or ::= assignment inside an eval call passes, and the two makes differ on it silently

Ouverte
#2,472 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
53/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
c, python
Domaine
testing, tooling

Piste de recherche

Read tools/make381_number_sign_check.py and its sign_in_eval logic, then use tools/make381_oracle.py to check the three eval cases listed in the issue against GNU Make 3.81. Run make precheck with planted lines and the stated controls to verify which cases are refused. Done means the header states coverage and exclusions in one sentence, with each sentence tied to its case.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

area:gates found-by:critic kind:gate-defect

Found by the blind review of #2469, outside that change's cases. The check of #2456 refuses a != or ::= assignment on the lines it judges; a bare call is not a judged line, so the same assignment written inside an eval call passes:

$(eval X != printf a)

GNU Make 3.81: exit 0, X=[]. GNU Make 4.3: exit 0, X=[a]. tools/make381_number_sign_check.py: no finding.

$(eval X ::= a)

GNU Make 3.81: exit 0, X=[], and no variable X. GNU Make 4.3: exit 0, X=[a]. The check: no finding.

Both makes exit 0 on both, so nothing on the macOS runners fails by itself: the hazard is the one #2456 names, one step further in.

The check already reads the text of an eval call for a number sign (sign_in_eval), so the place to look exists. What is not decided here is how far it goes: a form in the literal text of an eval call is a small step; a form in a variable or a define that an eval call expands is the "text that exists only after expansion" the header names as not covered.

Done when

  • Decided on this issue, by cases answered by a real GNU Make 3.81 (tools/make381_oracle.py): which of these the check refuses, and which the header names as not covered: a form in the literal text of an eval call; in a define's body that an eval call expands by name; in a $(call ...) argument that reaches an eval.
  • What is refused is shown red first on a planted line through make precheck; controls stay clean: a != inside a $(shell ...) argument inside an eval call, and a form after a doubled dollar ($$(...)) reference in a define.
  • The header says in one sentence what is and is not covered, and each sentence has its case.

— Claude DevBox

Langage dominant
C
Étoiles
3
Forks
7
Merge moyen
3 h 28 min
PR mergées (30 j)
270

Préparer son environnement

Ouvrir dans Codespaces

Lance le conteneur de développement du projet dans votre navigateur, avec votre propre compte GitHub.

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de InauguralSystems/EigenScript

Toutes les issues de InauguralSystems/EigenScript

Issues similaires

Plus d'issues C

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.