Cross-app runtime registry: known limitations to revisit

Aperta
#40 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
35/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
javascript
Ambito
backend

Direzione di ricerca

Read DESIGN.md under “Extension points, Across apps” and inspect src/index.ts (handleApplication) and src/runtime.ts (domain). The issue lists four deferred runtime registry limitations, but does not choose which one to address or define a resolution. First identify the intended limitation and its expected behavior with the maintainers; done would mean an agreed fix and coverage for that case.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Known limitations of the cross-app runtime registry added for #38. Each is documented in DESIGN.md (Extension points, Across apps) and was left out of that PR on purpose; this issue tracks revisiting them.

Duplicate plugins: the winner is picked per worker

When two apps on one Harper both list @harperfast/agent-memory, each worker keeps whichever plugin loaded first on that worker and fails the other (src/index.ts handleApplication). On a multi-worker pool, workers can pick differently, so two apps with different urlPath or limits would serve differently from worker to worker. It is a misconfiguration, and it fails loudly on every worker. Making the choice consistent would need coordination across workers, for example reading the root config to decide which app owns the plugin.

Review-Deferral: bef055bd07ccc70a severity=minor category=correctness

Duplicate plugins sharing one module instance are not rejected

Under the non-default native or compartment loader, two apps that resolve the package to the same file share one module instance. Its handleApplication runs twice, and the second run mounts again and overwrites settings, as it did before #38. The duplicate check compares runtime identity, so it cannot see this case. The docs limit the rejection to the default loaders.

Review-Deferral: c6697db96c4b23b4 severity=nit category=correctness

Registrations outlive the app that made them

A sink or resolver registered by an app that later fails to load stays in the worker's registry, and the plugin keeps calling it (src/runtime.ts domain). In-app hosting already behaves this way, because host and plugin share one instance. An importing app has no Scope through which to observe its own failure. Apps are only replaced on new workers, so a redeploy never leaves a stale runtime behind.

Review-Deferral: 1d29cbeb61c3524b severity=minor category=reliability

The version-skew warning compares majors only

foreignRuntime warns once when the importer's major version differs from the running plugin's, as the task specified. Between 0.x releases, where semver treats a minor bump as breaking, it stays silent. The shared protocol only gains members, so calls keep working. Comparing major.minor while the major is 0 would also warn on every expected independent upgrade.

Review-Deferral: 6fa14c337b5edc1b severity=nit category=correctness

Contributor names are checked by the registering copy only

registerSearchAnnotator rejects a name that is a search hit field, and registerBootstrapSection a built-in section name, using the lists in the registering copy of the package (src/extensions.ts register). Added in the bootstrap-section and search-annotator PR for #36. A copy registering beside a newer, separately upgraded plugin whose hits gained a field of the same name gets that field overwritten by its annotation. DESIGN.md (Extension points) tells plugin authors to pick a plugin-specific name. A dispatch-time recheck in the running plugin was built and then removed: contributors are trusted in-process code, as sinks are.

Review-Deferral: 8adc8f46716c1c03 severity=minor category=correctness

A contributor's malformed output can fail the request

Bootstrap sections and search annotators are trusted like sinks (DESIGN.md, Extension points). agent-memory contains a contributor's throw or rejection, but does not validate every shape it returns. One example: a sparse array of section items passes item validation, because Array.prototype.map skips holes, and then fails the whole bootstrap while packing. Array.from would catch it at no cost, but it was dropped along with the other shape defenses.

Review-Deferral: 45ab778fcd9fd78b severity=minor category=reliability

🤖 Generated by Claude Code (Claude Opus 5.5); posted via @kriszyp.

Lingua principale
JavaScript
Stelle
0
Fork
0
Merge medio
20h 29m
PR unite (30g)
28

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di HarperFast/agent-memory

Tutte le issue di HarperFast/agent-memory

Issue simili

Altre issue su JavaScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.