Cross-app runtime registry: known limitations to revisit
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 35/100
- Issue 类型
- 缺陷
- 描述清晰度
- 基本清楚
- 活跃度
- 活跃
- 技术栈
- javascript
- 领域
- backend
调研方向
Read DESIGN.md under “Extension points, Across apps” and inspect src/index.ts (handleApplication) and src/runtime.ts (domain). The issue lists four deferred runtime registry limitations, but does not choose which one to address or define a resolution. First identify the intended limitation and its expected behavior with the maintainers; done would mean an agreed fix and coverage for that case.
由索引模型根据 Issue 内容生成。
描述
Known limitations of the cross-app runtime registry added for #38. Each is documented in DESIGN.md (Extension points, Across apps) and was left out of that PR on purpose; this issue tracks revisiting them.
Duplicate plugins: the winner is picked per worker
When two apps on one Harper both list @harperfast/agent-memory, each worker keeps whichever plugin loaded first on that worker and fails the other (src/index.ts handleApplication). On a multi-worker pool, workers can pick differently, so two apps with different urlPath or limits would serve differently from worker to worker. It is a misconfiguration, and it fails loudly on every worker. Making the choice consistent would need coordination across workers, for example reading the root config to decide which app owns the plugin.
Review-Deferral: bef055bd07ccc70a severity=minor category=correctness
Duplicate plugins sharing one module instance are not rejected
Under the non-default native or compartment loader, two apps that resolve the package to the same file share one module instance. Its handleApplication runs twice, and the second run mounts again and overwrites settings, as it did before #38. The duplicate check compares runtime identity, so it cannot see this case. The docs limit the rejection to the default loaders.
Review-Deferral: c6697db96c4b23b4 severity=nit category=correctness
Registrations outlive the app that made them
A sink or resolver registered by an app that later fails to load stays in the worker's registry, and the plugin keeps calling it (src/runtime.ts domain). In-app hosting already behaves this way, because host and plugin share one instance. An importing app has no Scope through which to observe its own failure. Apps are only replaced on new workers, so a redeploy never leaves a stale runtime behind.
Review-Deferral: 1d29cbeb61c3524b severity=minor category=reliability
The version-skew warning compares majors only
foreignRuntime warns once when the importer's major version differs from the running plugin's, as the task specified. Between 0.x releases, where semver treats a minor bump as breaking, it stays silent. The shared protocol only gains members, so calls keep working. Comparing major.minor while the major is 0 would also warn on every expected independent upgrade.
Review-Deferral: 6fa14c337b5edc1b severity=nit category=correctness
Contributor names are checked by the registering copy only
registerSearchAnnotator rejects a name that is a search hit field, and registerBootstrapSection a built-in section name, using the lists in the registering copy of the package (src/extensions.ts register). Added in the bootstrap-section and search-annotator PR for #36. A copy registering beside a newer, separately upgraded plugin whose hits gained a field of the same name gets that field overwritten by its annotation. DESIGN.md (Extension points) tells plugin authors to pick a plugin-specific name. A dispatch-time recheck in the running plugin was built and then removed: contributors are trusted in-process code, as sinks are.
Review-Deferral: 8adc8f46716c1c03 severity=minor category=correctness
A contributor's malformed output can fail the request
Bootstrap sections and search annotators are trusted like sinks (DESIGN.md, Extension points). agent-memory contains a contributor's throw or rejection, but does not validate every shape it returns. One example: a sparse array of section items passes item validation, because Array.prototype.map skips holes, and then fails the whole bootstrap while packing. Array.from would catch it at no cost, but it was dropped along with the other shape defenses.
Review-Deferral: 45ab778fcd9fd78b severity=minor category=reliability
🤖 Generated by Claude Code (Claude Opus 5.5); posted via @kriszyp.
- 主要语言
- JavaScript
- 星标
- 0
- 派生
- 0
- 平均合并
- 20 小时 29 分钟
- 30 天内合并 PR
- 28
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
HarperFast/agent-memory 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 72/100
HarperFast/agent-memory#17 ·
维护者通常 1 天内回复
-
难度 5/5 一周以上 新手友好度 18/100
HarperFast/agent-memory#54 ·
维护者通常 1 天内回复
-
难度 4/5 3-5 天 新手友好度 25/100
HarperFast/agent-memory#53 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 52/100
HarperFast/agent-memory#48 ·
维护者通常 1 天内回复
-
难度 3/5 1-2 天 新手友好度 65/100
HarperFast/agent-memory#47 ·
维护者通常 1 天内回复
查看 HarperFast/agent-memory 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 3 天内回复
-
难度 2/5 1-3 小时 新手友好度 76/100
维护者通常 1 天内回复
-
ACK_WAITING HELP_WANTED UPDATE_CS
难度 2/5 1-3 小时 新手友好度 76/100
OWASP/CheatSheetSeries#3000 ·
维护者通常 1 天内回复
-
enhancement
难度 1/5 1 小时以内 新手友好度 82/100
fishjar/kiss-translator#1381 ·
维护者通常 1 天内回复
-
Client execution contract accepts a grant the code never takes可能已有人在做 关联的 PR 仍在进行中或已合并。 未关闭area: client enhancement priority: medium
难度 2/5 1-3 小时 新手友好度 78/100
opensro-dev/opensro#3808 ·
维护者通常 1 天内回复