Bootstrap fit: residual cases of the plugin's fixed per-entry framing estimate

Aperta
#53 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
25/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
javascript
Ambito
api, tooling

Direzione di ricerca

Start from the server's GET /Memory/bootstrap response, where entryOverhead and sectionItemOverhead are added by PR #50, and from the plugin's fixed per-entry framing estimate (~308 chars) and its ordered-prefix render. Reproduce case 1 with a pin whose title + content is about 3,420–3,530 chars at the default 4,000 budget, then case 2 with a lastEditor or longer scopes. The fix needs a decision on whether the server counts provenance strings, so settle that with maintainers first. Done means every entry that fits the budget is injected or the omission is explained.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Deferred from Claude Code plugin: inject all of bootstrap within budget, render section entries and summaryTree topics review.

That PR adds entryOverhead and sectionItemOverhead to GET /Memory/bootstrap. The Claude Code plugin sends a fixed per-entry framing estimate, computed from its own header format for an entry with:

  • a 64-char id
  • a 32-char author and no lastEditor
  • 64 chars of scopes
  • the longest built-in section

That estimate is ~308 chars per memory; typical entries frame in ~180–220. Because it is one constant per request, three cases remain:

  1. Boundary window. An entry whose title + content comes within about the estimate's slack (~100 chars) of the request budget is not packed, even though it would render within the injection budget. At the default 4,000 budget this is a pin with title + content of about 3,420–3,530 chars. The authoritative offline-cache save then leaves it out too.
  2. Metadata beyond the estimate. The server packs these entries, but the plugin's ordered-prefix render stops at the first one that does not fit, and the rest of the response is not injected. They stay in watchedIds. Examples:
    • a lastEditor
    • principal ids longer than 32 chars
    • more than ~64 chars of scopes (up to 16 × 128 are legal)
    • escaped characters, or bodies that sanitizing lengthens
  3. Offline cache render. The stale-cache path renders with skip-ahead rather than the ordered prefix. That is deliberate (the cache was packed for an earlier request), but it differs from the online path.

Possible fix for 1 and 2: the server also counts each entry's provenance strings (id, author, lastEditor, scopes, section), so the client's overhead covers only its fixed framing. That puts one client's header field list in the server contract, which is why the PR shipped the constant.

Review-Deferral: 3e7b1f54450ae2b7 severity=nit category=correctness
Review-Deferral: d4b1192533479e66 severity=nit category=correctness

Lingua principale
JavaScript
Stelle
0
Fork
0
Merge medio
20h 29m
PR unite (30g)
28

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di HarperFast/agent-memory

Tutte le issue di HarperFast/agent-memory

Issue simili

Altre issue su JavaScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.