Code hygiene: imports, deprecated ggplot2/scales APIs, loops, progress bars, roxygen

Aperta
  • Qualcosa non va?
#211 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
40/100
Tipo di issue
Refactoring
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
r
Ambito
tooling

Direzione di ricerca

Start with the individual sites listed in R/psa.R, R/add_common_aes.R, R/owsa.R, and R/run_dsa.R, and check each against the ggplot2/scales/dplyr changes it describes. Begin with the simplest fix, adding @importFrom stats cor in R/psa.R and confirming the NAMESPACE update. Done means devtools::check() shows no new NOTEs and the tests pass with options(lifecycle_verbosity = "error") without deprecation warnings. Coordinate with #213 for the ggplot2 version bump before changing the trans arguments.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug good first issue

Suggested owner: Jorge Roa (or a newer contributor) · Plan: Phase 2b

Goal

Remove the deprecation warnings and latent errors that will break on future ggplot2 or R versions, and that JOSS and CRAN reviewers notice.

Scope

  • cor() is used but not imported (R/psa.R:215, R/psa.R:306). Add @importFrom stats cor. The NAMESPACE imports other stats functions but not cor.
  • trans =, soft-deprecated since ggplot2 3.5 (R/add_common_aes.R:208, R/add_common_aes.R:221): switch to transform =. This needs ggplot2 (>= 3.5.0) in DESCRIPTION; see #213.
  • scales::trans_new() is superseded (R/owsa.R:300-302, offset_trans): use scales::new_transform().
  • .groups = "drop_last" passed to group_by(), where it creates a dummy column (R/owsa.R:353, R/owsa.R:356, R/owsa.R:361). It belongs in summarize().
  • Loops of the form for (i in 1:n) that misbehave when n == 0: use seq_len() / seq_along(). The calculate_icers site is handled by #178.
    • R/ceac.R:79, R/ceac.R:289
    • R/create_sa.R:76
    • R/evpi.R:45, R/evppi.R:93, R/evsi.R:173
    • R/gen_psa_samp.R:147, R/gen_psa_samp.R:230, R/gen_psa_samp.R:358 (the last is 1:(n.params - 1))
    • R/icers.R:95
    • R/run_dsa.R:108, R/run_dsa.R:135, R/run_dsa.R:155, R/run_dsa.R:305, R/run_dsa.R:318
    • R/run_psa.R:106, R/run_psa.R:118
  • Progress bars are never closed (R/run_dsa.R:119, R/run_dsa.R:289): add on.exit(close(pb)).
  • rdirichlet() roxygen tags are indented and therefore ignored (R/gen_psa_samp.R:273-275, #' @importFrom / #' @return / #' @export). Reproduced: dampack::rdirichlet is "not an exported object". Decide whether to export it or mark it @keywords internal, then fix the indentation.

Acceptance

  • devtools::check() shows no new NOTEs.
  • Running the tests with options(lifecycle_verbosity = "error") raises no ggplot2/scales deprecation warnings.
  • seq_len() changes are covered by existing tests, plus at least one 0-length test where reachable.
Lingua principale
R
Stelle
43
Fork
14
Merge medio
4h 44m
PR unite (30g)
15

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di DARTH-git/dampack

Tutte le issue di DARTH-git/dampack

Issue simili

Altre issue su R

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.