ReflectionProperty('\Phalcon\Http\Cookie', 'restored') breaks on Phalcon 5.13+ (renamed to isRestored)
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 3/5
- Tempo stimato
- 1-2 giorni
- Idoneità per principianti
- 68/100
- Tipo di issue
- Bug
- Chiarezza
- Abbastanza chiara
- Stato di attività
- Attiva
- Stack tecnologico
- php
- Ambito
- testing-qa
Direzione di ricerca
Start in src/Codeception/Lib/Connector/Phalcon5.php at doRequest(), especially the ReflectionProperty usage around line 145. Reproduce through the Phalcon5 _request() path with a non-empty cookies service on Phalcon 5.12 and 5.13+, then verify that cookie synchronization completes without a ReflectionException on both versions.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Description
Codeception\Lib\Connector\Phalcon5::doRequest() uses reflection to read a protected restored property off Phalcon\Http\Cookie instances when syncing cookies back onto the simulated response:
$restoredProperty = new ReflectionProperty('\Phalcon\Http\Cookie', 'restored');
Phalcon renamed this property from restored to isRestored starting with Phalcon 5.13 (still named isRestored as of 5.20.3):
https://github.com/phalcon/cphalcon/blob/v5.20.3/phalcon/Http/Cookie.zep#L50
Any functional/acceptance test that dispatches a request through an app where the cookies DI service ends up with at least one entry now fails with:
ReflectionException: Property Phalcon\Http\Cookie::$restored does not exist
Steps to reproduce
- Use
codeception/module-phalcon5v2.0.1against a Phalcon app running Phalcon core>= 5.13(e.g. viaphalcon-sharedor any recentext-phalconbuild). - Dispatch any request through the
Phalcon5module's_request()(or a Codeception action built on it) where the app'scookiesservice has a non-emptycookiesarray by the time the response is built (e.g. because the session service was started during dispatch). - Observe the
ReflectionException.
Expected behavior
The connector should read whichever property name is correct for the installed Phalcon version, or simply use the public API (Phalcon\Http\Cookie doesn't appear to expose isRestored() publicly today - only getValue() triggers restore() internally) rather than reflecting into a specific protected property name.
Environment
codeception/module-phalcon5: v2.0.1 (latest on Packagist)- Phalcon core: 5.20.3 (via
phalcon/phalcon-sharedcompiled extension) - PHP: 8.3
Workaround
We're carrying a local Composer patch (via cweagans/composer-patches) that renames the reflected property from restored to isRestored, which is obviously not version-safe across Phalcon 5.12 vs 5.13+. Happy to open a PR if a version-tolerant approach (e.g. checking which property exists, or avoiding the private-property reflection entirely) would be welcome.
- Lingua principale
- PHP
- Stelle
- 6
- Fork
- 3
- Metriche di merge delle PR
- Nessuna PR unita negli ultimi 30g
Guida per i contributori
Nessuna guida per i contributori indicizzata per questo repository
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di Codeception/module-phalcon5
-
Difficoltà 4/5 3-5 giorni Idoneità per principianti 25/100
Codeception/module-phalcon5#11 · 2 commenti ·
Tutte le issue di Codeception/module-phalcon5
Issue simili
-
jira-created
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 70/100
nunomaduro/phpinsights#745 ·
-
status/awaiting_triage
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 90/100
WordPress/plugin-check#1486 ·
-
enhancement
Difficoltà 2/5 1-3 ore Idoneità per principianti 88/100
az-digital/az_quickstart#6019 ·