Hacktoberfest 2026 : les issues que les mainteneurs ont marquées pour octobre, ouvertes et accessibles aux débutants. Parcourir les issues Hacktoberfest

ReflectionProperty('\Phalcon\Http\Cookie', 'restored') breaks on Phalcon 5.13+ (renamed to isRestored)

Ouverte
  • Quelque chose ne va pas ?
#12 0 commentaires 0 réactions 1 personne assignée Voir sur GitHub

@niden y travaille déjà.

Depuis le 2/10/2026.

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
68/100
Type d'issue
Bug
Clarté
Plutôt claire
Activité
Active
Stack technique
php
Domaine
testing-qa

Piste de recherche

Start in src/Codeception/Lib/Connector/Phalcon5.php at doRequest(), especially the ReflectionProperty usage around line 145. Reproduce through the Phalcon5 _request() path with a non-empty cookies service on Phalcon 5.12 and 5.13+, then verify that cookie synchronization completes without a ReflectionException on both versions.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

bug

Description

Codeception\Lib\Connector\Phalcon5::doRequest() uses reflection to read a protected restored property off Phalcon\Http\Cookie instances when syncing cookies back onto the simulated response:

https://github.com/Codeception/module-phalcon5/blob/2.0.1/src/Codeception/Lib/Connector/Phalcon5.php#L145

$restoredProperty = new ReflectionProperty('\Phalcon\Http\Cookie', 'restored');

Phalcon renamed this property from restored to isRestored starting with Phalcon 5.13 (still named isRestored as of 5.20.3):

https://github.com/phalcon/cphalcon/blob/v5.20.3/phalcon/Http/Cookie.zep#L50

Any functional/acceptance test that dispatches a request through an app where the cookies DI service ends up with at least one entry now fails with:

ReflectionException: Property Phalcon\Http\Cookie::$restored does not exist

Steps to reproduce

  1. Use codeception/module-phalcon5 v2.0.1 against a Phalcon app running Phalcon core >= 5.13 (e.g. via phalcon-shared or any recent ext-phalcon build).
  2. Dispatch any request through the Phalcon5 module's _request() (or a Codeception action built on it) where the app's cookies service has a non-empty cookies array by the time the response is built (e.g. because the session service was started during dispatch).
  3. Observe the ReflectionException.

Expected behavior

The connector should read whichever property name is correct for the installed Phalcon version, or simply use the public API (Phalcon\Http\Cookie doesn't appear to expose isRestored() publicly today - only getValue() triggers restore() internally) rather than reflecting into a specific protected property name.

Environment

  • codeception/module-phalcon5: v2.0.1 (latest on Packagist)
  • Phalcon core: 5.20.3 (via phalcon/phalcon-shared compiled extension)
  • PHP: 8.3

Workaround

We're carrying a local Composer patch (via cweagans/composer-patches) that renames the reflected property from restored to isRestored, which is obviously not version-safe across Phalcon 5.12 vs 5.13+. Happy to open a PR if a version-tolerant approach (e.g. checking which property exists, or avoiding the private-property reflection entirely) would be welcome.

Langage dominant
PHP
Étoiles
6
Forks
3
Aucune PR mergée en 30 j

Préparer son environnement

  • Fournit un Dockerfile ou un fichier Docker Compose
  • Aucun modèle de pull request
  • Aucun guide de contribution

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de Codeception/module-phalcon5

Toutes les issues de Codeception/module-phalcon5

Issues similaires

Plus d'issues PHP

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.