Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

ReflectionProperty('\Phalcon\Http\Cookie', 'restored') breaks on Phalcon 5.13+ (renamed to isRestored)

Abierto
#12 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
68/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
php
Área
testing-qa

Línea de trabajo

Start in src/Codeception/Lib/Connector/Phalcon5.php at doRequest(), especially the ReflectionProperty usage around line 145. Reproduce through the Phalcon5 _request() path with a non-empty cookies service on Phalcon 5.12 and 5.13+, then verify that cookie synchronization completes without a ReflectionException on both versions.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Description

Codeception\Lib\Connector\Phalcon5::doRequest() uses reflection to read a protected restored property off Phalcon\Http\Cookie instances when syncing cookies back onto the simulated response:

https://github.com/Codeception/module-phalcon5/blob/2.0.1/src/Codeception/Lib/Connector/Phalcon5.php#L145

$restoredProperty = new ReflectionProperty('\Phalcon\Http\Cookie', 'restored');

Phalcon renamed this property from restored to isRestored starting with Phalcon 5.13 (still named isRestored as of 5.20.3):

https://github.com/phalcon/cphalcon/blob/v5.20.3/phalcon/Http/Cookie.zep#L50

Any functional/acceptance test that dispatches a request through an app where the cookies DI service ends up with at least one entry now fails with:

ReflectionException: Property Phalcon\Http\Cookie::$restored does not exist

Steps to reproduce

  1. Use codeception/module-phalcon5 v2.0.1 against a Phalcon app running Phalcon core >= 5.13 (e.g. via phalcon-shared or any recent ext-phalcon build).
  2. Dispatch any request through the Phalcon5 module's _request() (or a Codeception action built on it) where the app's cookies service has a non-empty cookies array by the time the response is built (e.g. because the session service was started during dispatch).
  3. Observe the ReflectionException.

Expected behavior

The connector should read whichever property name is correct for the installed Phalcon version, or simply use the public API (Phalcon\Http\Cookie doesn't appear to expose isRestored() publicly today - only getValue() triggers restore() internally) rather than reflecting into a specific protected property name.

Environment

  • codeception/module-phalcon5: v2.0.1 (latest on Packagist)
  • Phalcon core: 5.20.3 (via phalcon/phalcon-shared compiled extension)
  • PHP: 8.3

Workaround

We're carrying a local Composer patch (via cweagans/composer-patches) that renames the reflected property from restored to isRestored, which is obviously not version-safe across Phalcon 5.12 vs 5.13+. Happy to open a PR if a version-tolerant approach (e.g. checking which property exists, or avoiding the private-property reflection entirely) would be welcome.

Lenguaje dominante
PHP
Estrellas
6
Forks
3
Métricas de merge de PR
Sin PR fusionados en 30 d

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de Codeception/module-phalcon5

Todos los issues de Codeception/module-phalcon5

Issues similares

Más issues de PHP

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.