sync seems to ignore --exclude-dir-regex

Aperta
  • Qualcosa non va?
#1,041 0 commenti 2 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
35/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Ferma
Stack tecnologico
python
Ambito
cli

Direzione di ricerca

The traceback ends in _walk_relative_paths in b2sdk's scan/folder.py (around lines 239-258), which calls pathlib iterdir on a subdirectory that the --exclude-dir-regex should have skipped. Read that walk and check whether the exclude-dir check runs before the recursion descends. Reproduce with a tree that contains an unreadable directory matching the regex. Done when the excluded directory is skipped without being opened, and the sync command finishes without a PermissionError.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Greetings,

While using the sync command on b2-windows version 4.1.0 on Windows 11 (x86_64), the program gives an error message when it hits a directory it cannot access, even when that directory is in --exclude-dir-regex.

Command-line (run in terminal as an administrator):

b2-windows.exe sync --skip-newer --threads 1 --destination-server-side-encryption=SSE-C --no-progress --exclude-all-symlinks --exclude-dir-regex=".*\\Users\\Temp|.*\\Default User|.*\\Users\\Default" --keep-days 60 "C:\Users" b2:bucketname/syncs/lap-24/C/Users

I receive this error

Traceback (most recent call last):
  File "b2\_internal\b2v4\__main__.py", line 13, in <module>
  File "b2\_internal\console_tool.py", line 5529, in main
  File "b2\_internal\console_tool.py", line 5402, in run_command
  File "b2\_internal\console_tool.py", line 1070, in run
  File "b2\_internal\console_tool.py", line 3165, in _run
  File "b2sdk\_internal\sync\sync.py", line 214, in sync_folders
  File "b2sdk\_internal\sync\sync.py", line 263, in _make_folder_sync_actions
  File "b2sdk\_internal\scan\scan.py", line 48, in zip_folders
  File "b2sdk\_internal\scan\folder.py", line 152, in all_files
  File "b2sdk\_internal\scan\folder.py", line 258, in _walk_relative_paths
  File "b2sdk\_internal\scan\folder.py", line 258, in _walk_relative_paths
  File "b2sdk\_internal\scan\folder.py", line 258, in _walk_relative_paths
  [Previous line repeated 1 more time]
  File "b2sdk\_internal\scan\folder.py", line 239, in _walk_relative_paths
  File "pathlib.py", line 1056, in iterdir
PermissionError: [WinError 5] Access is denied: '\\\\?\\C:\\Users\\Default\\AppData\\Local\\Application Data'
[6520] Failed to execute script '__main__' due to unhandled exception!

When testing the regex in a web-tester, it appears to be correct
image

The program shouldn't be attempting to access a subdirectory of an excluded directory. According to the command-line tool documentation:

When a directory is excluded by using --exclude-dir-regex, all of the files within it are excluded, even if they match an --include-regex pattern. This means that there is no need to look inside excluded directories, and you can exclude directories containing files for which you don’t have read permission and avoid getting errors.

Thanks 👍

Lingua principale
Python
Stelle
638
Fork
138
Merge medio
8h 27m
PR unite (30g)
8

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di Backblaze/B2_Command_Line_Tool

Tutte le issue di Backblaze/B2_Command_Line_Tool

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.