sync seems to ignore --exclude-dir-regex

Abierto
  • ¿Algo no está bien?
#1,041 0 comentarios 2 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
35/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Estancado
Stack tecnológico
python
Área
cli

Línea de trabajo

The traceback ends in _walk_relative_paths in b2sdk's scan/folder.py (around lines 239-258), which calls pathlib iterdir on a subdirectory that the --exclude-dir-regex should have skipped. Read that walk and check whether the exclude-dir check runs before the recursion descends. Reproduce with a tree that contains an unreadable directory matching the regex. Done when the excluded directory is skipped without being opened, and the sync command finishes without a PermissionError.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Greetings,

While using the sync command on b2-windows version 4.1.0 on Windows 11 (x86_64), the program gives an error message when it hits a directory it cannot access, even when that directory is in --exclude-dir-regex.

Command-line (run in terminal as an administrator):

b2-windows.exe sync --skip-newer --threads 1 --destination-server-side-encryption=SSE-C --no-progress --exclude-all-symlinks --exclude-dir-regex=".*\\Users\\Temp|.*\\Default User|.*\\Users\\Default" --keep-days 60 "C:\Users" b2:bucketname/syncs/lap-24/C/Users

I receive this error

Traceback (most recent call last):
  File "b2\_internal\b2v4\__main__.py", line 13, in <module>
  File "b2\_internal\console_tool.py", line 5529, in main
  File "b2\_internal\console_tool.py", line 5402, in run_command
  File "b2\_internal\console_tool.py", line 1070, in run
  File "b2\_internal\console_tool.py", line 3165, in _run
  File "b2sdk\_internal\sync\sync.py", line 214, in sync_folders
  File "b2sdk\_internal\sync\sync.py", line 263, in _make_folder_sync_actions
  File "b2sdk\_internal\scan\scan.py", line 48, in zip_folders
  File "b2sdk\_internal\scan\folder.py", line 152, in all_files
  File "b2sdk\_internal\scan\folder.py", line 258, in _walk_relative_paths
  File "b2sdk\_internal\scan\folder.py", line 258, in _walk_relative_paths
  File "b2sdk\_internal\scan\folder.py", line 258, in _walk_relative_paths
  [Previous line repeated 1 more time]
  File "b2sdk\_internal\scan\folder.py", line 239, in _walk_relative_paths
  File "pathlib.py", line 1056, in iterdir
PermissionError: [WinError 5] Access is denied: '\\\\?\\C:\\Users\\Default\\AppData\\Local\\Application Data'
[6520] Failed to execute script '__main__' due to unhandled exception!

When testing the regex in a web-tester, it appears to be correct
image

The program shouldn't be attempting to access a subdirectory of an excluded directory. According to the command-line tool documentation:

When a directory is excluded by using --exclude-dir-regex, all of the files within it are excluded, even if they match an --include-regex pattern. This means that there is no need to look inside excluded directories, and you can exclude directories containing files for which you don’t have read permission and avoid getting errors.

Thanks 👍

Lenguaje dominante
Python
Estrellas
638
Forks
138
Merge medio
8 h 27 min
PR fusionados (30 d)
8

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de Backblaze/B2_Command_Line_Tool

Todos los issues de Backblaze/B2_Command_Line_Tool

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.