Redact smb://, sftp:// and ssh:// paths in the trace scrub
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 83/100
Research direction
Read dokimi/repos/host_fingerprint.py and inspect _PATH, then find the existing path scrub tests. Add cases for smb://, sftp:// and ssh:// covering plain paths, quoted paths with spaces, and uppercase schemes; preserve each scheme while replacing its path with <path>. Run the relevant tests and confirm all cases pass.
Written by the indexing model from the issue text.
Description
#781 redacts file: URLs and UNC paths in error text (_PATH in dokimi/repos/host_fingerprint.py). The trace scrub still lets other URL schemes through.
Probe on the _PATH regex from #781 (its sub with <path>):
cp smb://fileserver/share/Jane/secret.txt hereis unchanged.sftp://jdoe@host/home/jdoe/keyis unchanged.ssh://jdoe@host/home/jdoe/xis unchanged.file:///home/jdoe/xbecomes<path>, and so does\\srv\share\x.
The absolute-path branch excludes a / after : (the scheme: before //), and the UNC branch needs // not preceded by :, so the host and path after smb://, sftp:// and ssh:// are not redacted.
Ask: redact smb://, sftp:// and ssh:// paths in the trace scrub the way file:// is redacted (the scheme kept, the path replaced by <path>), with a test per scheme for a plain path, a quoted path with a space, and an uppercase scheme.
Follow-up to #781 (its path scrub handles file: and UNC only).
- Dominant language
- Python
- Stars
- 39
- Forks
- 13
- Avg merge
- 1d 10h
- Merged PRs (30d)
- 519
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from intel/dokimi
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
Similar issues
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
dgunning/edgartools#2019 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
topoteretes/cognee#6818 · 1 comment ·
Maintainers usually reply within 1 day
-
source_verification_agent: no outcome when the publisher confirms a work but its DOI resolves to a different recordPossibly taken @pinjun99 claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Imbad0202/academic-research-skills#1159 · 1 comment ·
Maintainers usually reply within 1 day
-
[Bug]: DoubleMLData.from_arrays checks the treatment d with force_all_x_finite instead of force_all_d_finitePossibly taken @leninworld claimed this today. Open
Difficulty 1/5 Under an hour Newbie friendliness 88/100
DoubleML/doubleml-for-py#471 ·
Maintainers usually reply within 1 day
-
bug needs-triage
Difficulty 1/5 Under an hour Newbie friendliness 65/100
superdesigndev/treg#1879 ·
Maintainers usually reply within 1 day