mypy arg-type in tests/test_catalog_ignore.py:208

Open Beginner friendly
#1,125 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
62/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
python
Domain
testing

Research direction

The mypy error is at line 208 of tests/test_catalog_ignore.py, where codes.add(node.args[1].value) adds a value of a wider type to a set[str]. Start by running mypy on that file to reproduce the arg-type error, then check what node.args[1] is at that point. Done means mypy passes on main with the test file's behaviour unchanged, which the existing tests in that file can confirm.

Written by the indexing model from the issue text.

Description

Raised in the review of PR #839 (intel/dokimi), thread IC_kwDOVBg7g88AAAABpf-V4Q: https://github.com/intel/dokimi/pull/839

codes.add(node.args[1].value) adds a value typed str/bytes/int/float/... to a set[str]; mypy fails on main. Outside the lines this PR changes (the file is not in PR 839).

Not fixed in PR #839: it is outside the lines that PR changes (another component, a design change, or too large for the round).

Dominant language
Python
Stars
39
Forks
13
Avg merge
1d 10h
Merged PRs (30d)
519

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from intel/dokimi

All issues in intel/dokimi

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.