catalog: load_skill reads a symlinked SKILL.md before the containment check
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 62/100
Research direction
Start in dokimi/external/catalog.py around lines 232 and 236, where load_skill(path) runs before the _within(skill.path, root) containment check. Resolve the path and check containment before any read. Add a test that proves the symlinked outside file is never opened; the existing Path.read_text spy cannot see that read, so use a different spy or check. Done when the outside file is never read and the new test passes.
Written by the indexing model from the issue text.
Description
Raised in the review of PR #838 (intel/dokimi), thread IC_kwDOVBg7g88AAAABpjlHlw: https://github.com/intel/dokimi/pull/838
dokimi/external/catalog.py calls load_skill(path) before checking _within(skill.path, root) (lines 232 and 236, same on intel/main). A SKILL.md symlinked to a file outside the root is read before it is refused. Found in review of #838; the existing test's Path.read_text spy cannot see the read. Fix: check the resolved path before reading, and add a test that the outside file is never opened.
Not fixed in PR #838: it is outside the lines that PR changes (another component, a design change, or too large for the round).
- Dominant language
- Python
- Stars
- 39
- Forks
- 13
- Avg merge
- 1d 10h
- Merged PRs (30d)
- 519
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from intel/dokimi
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
Similar issues
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
dgunning/edgartools#2019 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
topoteretes/cognee#6818 · 1 comment ·
Maintainers usually reply within 1 day
-
source_verification_agent: no outcome when the publisher confirms a work but its DOI resolves to a different recordPossibly taken @pinjun99 claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Imbad0202/academic-research-skills#1159 · 1 comment ·
Maintainers usually reply within 1 day
-
[Bug]: DoubleMLData.from_arrays checks the treatment d with force_all_x_finite instead of force_all_d_finitePossibly taken @leninworld claimed this today. Open
Difficulty 1/5 Under an hour Newbie friendliness 88/100
DoubleML/doubleml-for-py#471 ·
Maintainers usually reply within 1 day
-
bug needs-triage
Difficulty 1/5 Under an hour Newbie friendliness 65/100
superdesigndev/treg#1879 ·
Maintainers usually reply within 1 day