Proxy: one table test for "who is asked" by tool and permission mode
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 57/100
Research direction
Start from the existing needsPermission test on dev, the tool registry, and docs/CLI.md; trace the command route for the argument-parse check, runBlockAfterTraceback, and tool lookup. Add coverage for every registered tool across the three permission modes and for the three route steps and a short ATLAS_PERMISSION_TIMEOUT_SEC. Done when adding a tool without a table row fails the test and all requested tests exist.
Written by the indexing model from the issue text.
Description
What needs doing
- A test of
needsPermissionover every registered tool and the
three permission modes, driven from the tool registry. Part of
this exists ondev; start from what is there. - Tests for three steps of the command route that have none: the
argument-parse check,runBlockAfterTraceback, and the tool
lookup. - A test of the approval timeout with a short
ATLAS_PERMISSION_TIMEOUT_SEC.
Why
docs/CLI.md states this table. A test keeps the docs and the code
together when a tool is added.
Done when
- A new tool without a row fails the table test.
- The three step tests and the timeout test exist.
- Dominant language
- Python
- Stars
- 2.1k
- Forks
- 197
- Avg merge
- 14h 39m
- Merged PRs (30d)
- 188
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from inferstep/ATLAS
-
Bootstrap: the last two steps run as the user who owns the installMay be free again @assassinationss claimed this 12 days ago, and no pull request is open. Openarea/install reliability
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
inferstep/ATLAS#412 · 4 comments ·
Maintainers usually reply within 1 day
-
area/cli
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
area/cli area/lens status/ready
Difficulty 2/5 Half a day Newbie friendliness 66/100
Maintainers usually reply within 1 day
-
area/ci status/ready
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
inferstep/ATLAS#245 · 4 comments ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 55/100
Maintainers usually reply within 1 day
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
zach-blumenfeld/aip#13 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
nathanmarlor/foxess_modbus#1287 ·
Maintainers usually reply within 4 days
-
bug good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
OpenLakeForge/openlakeforge#498 ·
Maintainers usually reply within 1 day
-
good first issue hacktoberfest help wanted python
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 69/100
pollen-robotics/reachy_mini#1493 ·
Maintainers usually reply within 1 day