V3 service: limit the request size and answer every parse error in one shape
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 72/100
Research direction
Start in v3-service/main.py and trace how each route reads the request body and how the two parse-only routes handle parser errors. Add tests for each route covering an oversized body (413) and a parser error (4xx), and document the single request-size limit in docs/CONFIGURATION.md; done means all those tests pass and the configuration names the limit.
Written by the indexing model from the issue text.
Description
What needs doing
- One upper limit for the request body on every route. Today each
route reads the announced length as it is given. - The two parse-only routes answer every parser error, not only a
syntax error, with the service's error shape.
Why
The proxy limits its request bodies. The service behind it does not.
Done when
- A test per route for a body over the limit (413) and for a
parser error (4xx). - The limit is one constant, named in
docs/CONFIGURATION.md.
Where to start
v3-service/main.py.
- Dominant language
- Python
- Stars
- 2.1k
- Forks
- 197
- Avg merge
- 14h 1m
- Merged PRs (30d)
- 201
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from inferstep/ATLAS
-
Bootstrap: the last two steps run as the user who owns the installMay be free again @assassinationss claimed this 14 days ago, and no pull request is open. Openarea/install reliability
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
inferstep/ATLAS#412 · 4 comments ·
Maintainers usually reply within 1 day
-
area/cli
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
area/cli area/lens status/ready
Difficulty 2/5 Half a day Newbie friendliness 66/100
Maintainers usually reply within 1 day
-
area/ci status/ready
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
inferstep/ATLAS#245 · 4 comments ·
Maintainers usually reply within 1 day
-
area/docs documentation help wanted status/ready
Difficulty 4/5 3-5 days Newbie friendliness 55/100
Maintainers usually reply within 1 day
Similar issues
-
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
fossasia/visdom-dev#69 ·
Maintainers usually reply within 3 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
BUG: PROD: v1.3.0-beta Onboarding Profile Picture Misaligns When Name Validation Error AppearsPossibly taken @RitikaSen27 claimed this today. Openbug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
AOSSIE-Org/PictoPy#1647 · 2 comments ·
Maintainers usually reply within 2 days
-
[oblt-aw][autodoc] Update workflow docs for gh-aw v0.92.5 and detector permission scopePossibly taken @github-actions claimed this today. Open
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day