Pillars (Bars) on side do not shrink or expand as photo zooms in and out
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
Research direction
The payload names no source file, so start by searching the web display code for the zoom effect and the fill setting. Reproduce with fill off and zoom on, using one landscape and one portrait photo, and compare how the top/bottom bars and the side bars are sized. Done when the side bars shrink and expand with the zoom the same way the top and bottom bars do.
Written by the indexing model from the issue text.
Description
Version
v1.0.29.0
Deployment Method
Web
Description
With zoom effect enabled and the fill setting disabled, when a landscape photo does not fit the frame aspect ratio and bars are added on top and bottom to fill the frame, the bars will shrink as the photo zooms in. Or, put another way, the photo expands to displace the bars as it zooms in. If instead the photo starts out zoomed in and gradually zooms out, the bars will start out small to allow the top and bottom of the photo to show even though the sides are cropped.
However, on a portrait photo, if bars are added on the left and right sides to fill the frame, then the bars are static. As the photo zooms in/out, the photo is cropped to fit within those side bars, even as the photo zooms in and could fill more of the frame.
I would expect the bars on the sides to behave the same as bars added to the top and bottom.
Reproduction
- Set ImmichFrame to have fill turned off and zoom effect turned on.
- Observe how bars on the top and bottom adjust to maximize how much of the photo is visible.
- Observe how bars on left and right are locked and the zooming photo is artificially cropped to fit within those sidebars.
Expectations
Side bars would behave the same as top and bottom bars.
Configuration
Logs
Pre-Submission Checklist
-
This is a bug report and not a feature request
-
I have provided all of the required information to reproduce the bug (config, logs, etc.)
-
I have checked for related issues and checked the documentation
- Dominant language
- C#
- Stars
- 2.4k
- Forks
- 121
- Avg merge
- 18d 20h
- Merged PRs (30d)
- 1
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from immichFrame/ImmichFrame
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
immichFrame/ImmichFrame#735 ·
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 56/100
immichFrame/ImmichFrame#733 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 76/100
immichFrame/ImmichFrame#732 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 22/100
immichFrame/ImmichFrame#731 · 1 reaction ·
-
enhancement
Difficulty 4/5 3-5 days Newbie friendliness 48/100
immichFrame/ImmichFrame#729 ·
All issues in immichFrame/ImmichFrame
Similar issues
-
Difficulty 1/5 1-3 hours Newbie friendliness 74/100
dotnet/EntityFramework.Docs#5521 ·
Maintainers usually reply within 1 day
-
Feature needs response
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Adyen/adyen-dotnet-api-library#1907 ·
Maintainers usually reply within 5 days
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
dimitar-radenkov/Pointframe#318 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
DotHarness/dotcraft#546 ·
Maintainers usually reply within 1 day
-
a-corriger bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
christian-raj/S-Aloha#303 · 1 comment ·