Pillars (Bars) on side do not shrink or expand as photo zooms in and out

Aperta
  • Qualcosa non va?
#500 1 commento 1 reazione 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
45/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Ferma
Stack tecnologico
csharp
Ambito
frontend

Direzione di ricerca

The payload names no source file, so start by searching the web display code for the zoom effect and the fill setting. Reproduce with fill off and zoom on, using one landscape and one portrait photo, and compare how the top/bottom bars and the side bars are sized. Done when the side bars shrink and expand with the zoom the same way the top and bottom bars do.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug
Version

v1.0.29.0

Deployment Method

Web

Description

With zoom effect enabled and the fill setting disabled, when a landscape photo does not fit the frame aspect ratio and bars are added on top and bottom to fill the frame, the bars will shrink as the photo zooms in. Or, put another way, the photo expands to displace the bars as it zooms in. If instead the photo starts out zoomed in and gradually zooms out, the bars will start out small to allow the top and bottom of the photo to show even though the sides are cropped.

However, on a portrait photo, if bars are added on the left and right sides to fill the frame, then the bars are static. As the photo zooms in/out, the photo is cropped to fit within those side bars, even as the photo zooms in and could fill more of the frame.

I would expect the bars on the sides to behave the same as bars added to the top and bottom.

Reproduction
  1. Set ImmichFrame to have fill turned off and zoom effect turned on.
  2. Observe how bars on the top and bottom adjust to maximize how much of the photo is visible.
  3. Observe how bars on left and right are locked and the zooming photo is artificially cropped to fit within those sidebars.
Expectations

Side bars would behave the same as top and bottom bars.

Configuration
Logs
Pre-Submission Checklist

  • This is a bug report and not a feature request

  • I have provided all of the required information to reproduce the bug (config, logs, etc.)

  • I have checked for related issues and checked the documentation

Lingua principale
C#
Stelle
2.4k
Fork
121
Merge medio
18g 20h
PR unite (30g)
1

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di immichFrame/ImmichFrame

Tutte le issue di immichFrame/ImmichFrame

Issue simili

Altre issue su C#

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.