Pillars (Bars) on side do not shrink or expand as photo zooms in and out

Abierto
  • ¿Algo no está bien?
#500 1 comentario 1 reacción 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
45/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Estancado
Stack tecnológico
csharp
Área
frontend

Línea de trabajo

The payload names no source file, so start by searching the web display code for the zoom effect and the fill setting. Reproduce with fill off and zoom on, using one landscape and one portrait photo, and compare how the top/bottom bars and the side bars are sized. Done when the side bars shrink and expand with the zoom the same way the top and bottom bars do.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug
Version

v1.0.29.0

Deployment Method

Web

Description

With zoom effect enabled and the fill setting disabled, when a landscape photo does not fit the frame aspect ratio and bars are added on top and bottom to fill the frame, the bars will shrink as the photo zooms in. Or, put another way, the photo expands to displace the bars as it zooms in. If instead the photo starts out zoomed in and gradually zooms out, the bars will start out small to allow the top and bottom of the photo to show even though the sides are cropped.

However, on a portrait photo, if bars are added on the left and right sides to fill the frame, then the bars are static. As the photo zooms in/out, the photo is cropped to fit within those side bars, even as the photo zooms in and could fill more of the frame.

I would expect the bars on the sides to behave the same as bars added to the top and bottom.

Reproduction
  1. Set ImmichFrame to have fill turned off and zoom effect turned on.
  2. Observe how bars on the top and bottom adjust to maximize how much of the photo is visible.
  3. Observe how bars on left and right are locked and the zooming photo is artificially cropped to fit within those sidebars.
Expectations

Side bars would behave the same as top and bottom bars.

Configuration
Logs
Pre-Submission Checklist

  • This is a bug report and not a feature request

  • I have provided all of the required information to reproduce the bug (config, logs, etc.)

  • I have checked for related issues and checked the documentation

Lenguaje dominante
C#
Estrellas
2.4k
Forks
121
Merge medio
18 d 20 h
PR fusionados (30 d)
1

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de immichFrame/ImmichFrame

Todos los issues de immichFrame/ImmichFrame

Issues similares

Más issues de C#

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.