inlineLength: validate (finite, >0, bounded) at part registration
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 69/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- react, three.js, typescript
- Domain
- backend
Research direction
Start by reading IsoPartDefinition and the registration validation, then compare their checks with routing/inline.ts and inlineBodyLength, which the issue says currently accepts zero and has no upper bound. Add registration bounds for finite positive values and determine the intended maximum from the project’s existing constraints; done when invalid values are rejected during registration and the validation is covered.
Written by the indexing model from the issue text.
Description
IsoPartDefinition.inlineLength is only guarded at runtime in routing/inline.ts inlineBodyLength (accepts 0, no upper bound). Add bounds in registration validation.
Raised in review of #204.
- Dominant language
- TypeScript
- Stars
- 0
- Forks
- 0
- Avg merge
- 11h 21m
- Merged PRs (30d)
- 41
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from hyperdrive-technology/holodeck
-
area:ci review-finding
Difficulty 2/5 1-3 hours Newbie friendliness 63/100
hyperdrive-technology/holodeck#208 ·
Maintainers usually reply within 1 day
-
area:holodeck review-finding
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
hyperdrive-technology/holodeck#207 ·
Maintainers usually reply within 1 day
-
area:holodeck review-finding
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
hyperdrive-technology/holodeck#206 ·
Maintainers usually reply within 1 day
-
area:holodeck review-finding
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
hyperdrive-technology/holodeck#201 · 1 comment ·
Maintainers usually reply within 1 day
-
area:holodeck review-finding
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
hyperdrive-technology/holodeck#196 ·
Maintainers usually reply within 1 day
All issues in hyperdrive-technology/holodeck
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
db-ux-design-system/core-web#8613 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
bug:new
Difficulty 1/5 Under an hour Newbie friendliness 78/100
callstackincubator/simlock#934 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
gchq/LD-Explorer#286 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
foxglove/mcap#1907 · 1 comment ·
Maintainers usually reply within 1 day