Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

Several woven classes in one file: their proxies overwrite each other, all but the last class are lost (Class not found)

Open
  • Is something wrong?
#760 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

@lisachenko is already working on this.

Since Oct 9, 2026.

  • #764 by @lisachenko — open

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
38/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
php
Domain
tooling

Research direction

Start in WeavingTransformer::saveProxyToCache() in src/Instrument/Transformer/WeavingTransformer.php (around lines 974-993), where the proxy path is built from the source file alone, and in the include lines the woven source gets. Read the snapshot tests multiple-classes-woven.php and multiple-ns.php under tests/Instrument/Transformer/_files/, then bump CachePathManager::FORMAT_VERSION if the layout changes. Done means one combined proxy file per source file, with every woven class in its own namespace, plus a test that actually loads all the classes.

Written by the indexing model from the issue text.

Description

Bug

Problem

When one source file declares several classes that are woven, every proxy is written to the same cache file. The last proxy wins, and the other classes are never defined at runtime.

Reproduce (master 4e95fdd)

// app/Two.php
namespace Bug1;
class First  { public function hello(): string { return 'first'; } }
class Second { public function hello(): string { return 'second'; } }

The aspect is #[Before('execution(public Bug1\**->hello(*))')]. The kernel uses appDir = app/.

After the file is included through the loader:

  • class_exists('Bug1\Second', false) → true; (new Second())->hello() runs the advice.
  • class_exists('Bug1\First', false) → false; new First() fails with Error: Class "Bug1\First" not found.
  • trait_exists('Bug1\FirstOriginalTrait', false) → true. The trait is woven, but its proxy class is gone.
  • cache/Two.php (the proxy file) contains only class Second.

Cause

  • WeavingTransformer::saveProxyToCache() (src/Instrument/Transformer/WeavingTransformer.php:974-993) builds the proxy path from the source file path only: {cacheDir}/{relative source path}. Each woven class of the file overwrites the previous proxy.
  • The woven source then contains one include_once AOP_CACHE_DIR . '/…/Two.php'; per class, all for the same path. The first one loads the last written proxy, and the later ones do nothing.

The existing snapshot tests/Instrument/Transformer/_files/multiple-classes-woven.php already encodes this: three classes share the identical include_once AOP_CACHE_DIR . '/Transformer/_files/multiple-classes.php'. The test never loads the classes, so it passes.

Expected / decided direction

Keep one proxy file per source file: put all proxies of the file together in that single cache file, not one file per class.

  • The woven source includes that file once, after all …OriginalTrait declarations it needs are defined.
  • The runtime class map (_include.cache) maps every woven class of the file to the same cached file.
  • Namespaces: a source file may declare classes in several namespaces (see multiple-ns.php). The combined proxy file has to keep every proxy in its own namespace, with its own imports, for example as braced namespace blocks.

Acceptance

  • The snapshot tests for multiple-classes and multiple-ns are updated, and a test actually loads all classes of such a file (unit or functional).
  • Classes in the same file that are not woven stay as they are.
  • Single-class files produce byte-identical output to master, or any difference is explained.
  • If the cache layout or format changes, bump CachePathManager::FORMAT_VERSION.
Dominant language
PHP
Stars
1.7k
Forks
166
Avg merge
11h 20m
Merged PRs (30d)
37

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from goaop/framework

All issues in goaop/framework

Similar issues

More PHP issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.