Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

Several woven classes in one file: their proxies overwrite each other, all but the last class are lost (Class not found)

Cerrado
  • ¿Algo no está bien?
#760 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

@lisachenko ya está trabajando en esto.

Desde el 9/10/2026.

  • #764 de @lisachenko — abierto

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
38/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
php
Área
tooling

Línea de trabajo

Start in WeavingTransformer::saveProxyToCache() in src/Instrument/Transformer/WeavingTransformer.php (around lines 974-993), where the proxy path is built from the source file alone, and in the include lines the woven source gets. Read the snapshot tests multiple-classes-woven.php and multiple-ns.php under tests/Instrument/Transformer/_files/, then bump CachePathManager::FORMAT_VERSION if the layout changes. Done means one combined proxy file per source file, with every woven class in its own namespace, plus a test that actually loads all the classes.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Bug

Problem

When one source file declares several classes that are woven, every proxy is written to the same cache file. The last proxy wins, and the other classes are never defined at runtime.

Reproduce (master 4e95fdd)

// app/Two.php
namespace Bug1;
class First  { public function hello(): string { return 'first'; } }
class Second { public function hello(): string { return 'second'; } }

The aspect is #[Before('execution(public Bug1\**->hello(*))')]. The kernel uses appDir = app/.

After the file is included through the loader:

  • class_exists('Bug1\Second', false) → true; (new Second())->hello() runs the advice.
  • class_exists('Bug1\First', false) → false; new First() fails with Error: Class "Bug1\First" not found.
  • trait_exists('Bug1\FirstOriginalTrait', false) → true. The trait is woven, but its proxy class is gone.
  • cache/Two.php (the proxy file) contains only class Second.

Cause

  • WeavingTransformer::saveProxyToCache() (src/Instrument/Transformer/WeavingTransformer.php:974-993) builds the proxy path from the source file path only: {cacheDir}/{relative source path}. Each woven class of the file overwrites the previous proxy.
  • The woven source then contains one include_once AOP_CACHE_DIR . '/…/Two.php'; per class, all for the same path. The first one loads the last written proxy, and the later ones do nothing.

The existing snapshot tests/Instrument/Transformer/_files/multiple-classes-woven.php already encodes this: three classes share the identical include_once AOP_CACHE_DIR . '/Transformer/_files/multiple-classes.php'. The test never loads the classes, so it passes.

Expected / decided direction

Keep one proxy file per source file: put all proxies of the file together in that single cache file, not one file per class.

  • The woven source includes that file once, after all …OriginalTrait declarations it needs are defined.
  • The runtime class map (_include.cache) maps every woven class of the file to the same cached file.
  • Namespaces: a source file may declare classes in several namespaces (see multiple-ns.php). The combined proxy file has to keep every proxy in its own namespace, with its own imports, for example as braced namespace blocks.

Acceptance

  • The snapshot tests for multiple-classes and multiple-ns are updated, and a test actually loads all classes of such a file (unit or functional).
  • Classes in the same file that are not woven stay as they are.
  • Single-class files produce byte-identical output to master, or any difference is explained.
  • If the cache layout or format changes, bump CachePathManager::FORMAT_VERSION.
Lenguaje dominante
PHP
Estrellas
1.7k
Forks
166
Merge medio
19 h 39 min
PR fusionados (30 d)
48

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de goaop/framework

Todos los issues de goaop/framework

Issues similares

Más issues de PHP

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.