Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Several woven classes in one file: their proxies overwrite each other, all but the last class are lost (Class not found)

Aperta
  • Qualcosa non va?
#760 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@lisachenko ci sta già lavorando.

Dal 9/10/2026.

  • #764 di @lisachenko — aperta

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
38/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
php
Ambito
tooling

Direzione di ricerca

Start in WeavingTransformer::saveProxyToCache() in src/Instrument/Transformer/WeavingTransformer.php (around lines 974-993), where the proxy path is built from the source file alone, and in the include lines the woven source gets. Read the snapshot tests multiple-classes-woven.php and multiple-ns.php under tests/Instrument/Transformer/_files/, then bump CachePathManager::FORMAT_VERSION if the layout changes. Done means one combined proxy file per source file, with every woven class in its own namespace, plus a test that actually loads all the classes.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Bug

Problem

When one source file declares several classes that are woven, every proxy is written to the same cache file. The last proxy wins, and the other classes are never defined at runtime.

Reproduce (master 4e95fdd)

// app/Two.php
namespace Bug1;
class First  { public function hello(): string { return 'first'; } }
class Second { public function hello(): string { return 'second'; } }

The aspect is #[Before('execution(public Bug1\**->hello(*))')]. The kernel uses appDir = app/.

After the file is included through the loader:

  • class_exists('Bug1\Second', false) → true; (new Second())->hello() runs the advice.
  • class_exists('Bug1\First', false) → false; new First() fails with Error: Class "Bug1\First" not found.
  • trait_exists('Bug1\FirstOriginalTrait', false) → true. The trait is woven, but its proxy class is gone.
  • cache/Two.php (the proxy file) contains only class Second.

Cause

  • WeavingTransformer::saveProxyToCache() (src/Instrument/Transformer/WeavingTransformer.php:974-993) builds the proxy path from the source file path only: {cacheDir}/{relative source path}. Each woven class of the file overwrites the previous proxy.
  • The woven source then contains one include_once AOP_CACHE_DIR . '/…/Two.php'; per class, all for the same path. The first one loads the last written proxy, and the later ones do nothing.

The existing snapshot tests/Instrument/Transformer/_files/multiple-classes-woven.php already encodes this: three classes share the identical include_once AOP_CACHE_DIR . '/Transformer/_files/multiple-classes.php'. The test never loads the classes, so it passes.

Expected / decided direction

Keep one proxy file per source file: put all proxies of the file together in that single cache file, not one file per class.

  • The woven source includes that file once, after all …OriginalTrait declarations it needs are defined.
  • The runtime class map (_include.cache) maps every woven class of the file to the same cached file.
  • Namespaces: a source file may declare classes in several namespaces (see multiple-ns.php). The combined proxy file has to keep every proxy in its own namespace, with its own imports, for example as braced namespace blocks.

Acceptance

  • The snapshot tests for multiple-classes and multiple-ns are updated, and a test actually loads all classes of such a file (unit or functional).
  • Classes in the same file that are not woven stay as they are.
  • Single-class files produce byte-identical output to master, or any difference is explained.
  • If the cache layout or format changes, bump CachePathManager::FORMAT_VERSION.
Lingua principale
PHP
Stelle
1.7k
Fork
166
Merge medio
11h 20m
PR unite (30g)
37

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di goaop/framework

Tutte le issue di goaop/framework

Issue simili

Altre issue su PHP

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.