Support for basic statically resolvable expressions in `container` field

Open
  • Is something wrong?
#236 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
48/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Active
Tech stack
github-actions, go
Domain
cli, security

Research direction

Start by tracing how gh actions-lock --verify reads the workflow container field and reports expressions it cannot resolve; the payload names no source files or tests. Check how matrix values are represented and whether statically defined include entries can supply container values. Done means verification can resolve these static matrix expressions while still warning about values chosen at runtime.

Written by the indexing model from the issue text.

Description

area:cli feature-request

Hi! When running gh actions-lock --verify , I get the warning below.

! container image `${{ matrix.container }}` is chosen at runtime, so the lockfile can't check it
  ↳ used by .github/workflows/build-ifcopenshell-linux.yml: job build container
  ↳ use a literal image pinned by digest where possible, or pin each value of the matrix or input by digest

Though this is mentioned in limitations in readme (This includes images chosen by a ${{ }} expression), is there any chance container can support resolving expressions that refer to static matrices?

In my case matrix is fully defined statically, so it's possible to infer the container value.

Otherwise to resolve this warning I need to drop matrices completely for such cases and instead split action in 2 jobs - either by moving the entire job code to a composite action or by using YAML anchors (e.g. steps: &build-steps in one job and steps: *build-steps in another).
Both result in less idiomatically written actions.

jobs:
  build:
    strategy:
      fail-fast: false
      matrix:
        include:
          - arch_suffix: linux64
            runner: ubuntu-22.04
            container:
              image: rockylinux:9@sha256:…
          - arch_suffix: linuxarm64
            runner: ubuntu-22.04-arm
            container:
              image: rockylinux/rockylinux:10@sha256:…
              env:
                PATH: /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
    name: build (${{ matrix.arch_suffix }})
    runs-on: ${{ matrix.runner }}
    container: ${{ matrix.container }}
Dominant language
Go
Stars
253
Forks
15
Avg merge
19h 30m
Merged PRs (30d)
60

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from github/gh-actions-lock

All issues in github/gh-actions-lock

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.