Support for basic statically resolvable expressions in `container` field

未关闭
#236 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
48/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
活跃
技术栈
github-actions, go
领域
cli, security

调研方向

Start by tracing how gh actions-lock --verify reads the workflow container field and reports expressions it cannot resolve; the payload names no source files or tests. Check how matrix values are represented and whether statically defined include entries can supply container values. Done means verification can resolve these static matrix expressions while still warning about values chosen at runtime.

由索引模型根据 Issue 内容生成。

描述

area:cli feature-request

Hi! When running gh actions-lock --verify , I get the warning below.

! container image `${{ matrix.container }}` is chosen at runtime, so the lockfile can't check it
  ↳ used by .github/workflows/build-ifcopenshell-linux.yml: job build container
  ↳ use a literal image pinned by digest where possible, or pin each value of the matrix or input by digest

Though this is mentioned in limitations in readme (This includes images chosen by a ${{ }} expression), is there any chance container can support resolving expressions that refer to static matrices?

In my case matrix is fully defined statically, so it's possible to infer the container value.

Otherwise to resolve this warning I need to drop matrices completely for such cases and instead split action in 2 jobs - either by moving the entire job code to a composite action or by using YAML anchors (e.g. steps: &build-steps in one job and steps: *build-steps in another).
Both result in less idiomatically written actions.

jobs:
  build:
    strategy:
      fail-fast: false
      matrix:
        include:
          - arch_suffix: linux64
            runner: ubuntu-22.04
            container:
              image: rockylinux:9@sha256:…
          - arch_suffix: linuxarm64
            runner: ubuntu-22.04-arm
            container:
              image: rockylinux/rockylinux:10@sha256:…
              env:
                PATH: /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
    name: build (${{ matrix.arch_suffix }})
    runs-on: ${{ matrix.runner }}
    container: ${{ matrix.container }}
主要语言
Go
星标
253
派生
15
平均合并
19 小时 30 分钟
30 天内合并 PR
60

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

github/gh-actions-lock 的其他 Issue

查看 github/gh-actions-lock 的全部 Issue

相似的 Issue

更多 Go Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。