Support for basic statically resolvable expressions in `container` field

Abierto
  • ¿Algo no está bien?
#236 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
48/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
github-actions, go
Área
cli, security

Línea de trabajo

Start by tracing how gh actions-lock --verify reads the workflow container field and reports expressions it cannot resolve; the payload names no source files or tests. Check how matrix values are represented and whether statically defined include entries can supply container values. Done means verification can resolve these static matrix expressions while still warning about values chosen at runtime.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area:cli feature-request

Hi! When running gh actions-lock --verify , I get the warning below.

! container image `${{ matrix.container }}` is chosen at runtime, so the lockfile can't check it
  ↳ used by .github/workflows/build-ifcopenshell-linux.yml: job build container
  ↳ use a literal image pinned by digest where possible, or pin each value of the matrix or input by digest

Though this is mentioned in limitations in readme (This includes images chosen by a ${{ }} expression), is there any chance container can support resolving expressions that refer to static matrices?

In my case matrix is fully defined statically, so it's possible to infer the container value.

Otherwise to resolve this warning I need to drop matrices completely for such cases and instead split action in 2 jobs - either by moving the entire job code to a composite action or by using YAML anchors (e.g. steps: &build-steps in one job and steps: *build-steps in another).
Both result in less idiomatically written actions.

jobs:
  build:
    strategy:
      fail-fast: false
      matrix:
        include:
          - arch_suffix: linux64
            runner: ubuntu-22.04
            container:
              image: rockylinux:9@sha256:…
          - arch_suffix: linuxarm64
            runner: ubuntu-22.04-arm
            container:
              image: rockylinux/rockylinux:10@sha256:…
              env:
                PATH: /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
    name: build (${{ matrix.arch_suffix }})
    runs-on: ${{ matrix.runner }}
    container: ${{ matrix.container }}
Lenguaje dominante
Go
Estrellas
295
Forks
21
Merge medio
1 d 3 h
PR fusionados (30 d)
64

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de github/gh-actions-lock

Todos los issues de github/gh-actions-lock

Issues similares

Más issues de Go

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.