Repo file links in the conversation are clickable when they refer to one line, but not when they select multiple lines.
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 66/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Domain
- desktop
Research direction
Start by reading the conversation’s repo file link handling and its tests; the issue gives apps/index.js:123 and apps/index.js:123-124 as reproductions. Find where single line references become clickable, then check the multi-line case. Done when the multi-line reference is clickable and opens the selected lines, with a test covering both examples.
Written by the indexing model from the issue text.
Description
Repo file links in the conversation are clickable when they refer to one line, but not when they select multiple lines.
E.g. apps/index.js:123 works and on click navigates to the line in the sidebar.
But apps/index.js:123-124 is not clickable.
| Field | Value |
|---|---|
| App version | 1.1.30 |
| OS | Windows 10.0.26200 |
| Theme | Fox |
| Path | /chat |
| Tenure | Week 12 |
Originally posted by @josefblaha-ext44919 in https://github.com/github/app/issues/4964
- Dominant language
- No language data
- Stars
- 2.2k
- Forks
- 194
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from github/app
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
triage
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
https://docs.Open
Difficulty 1/5 Under an hour Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
AvengeMedia/dank-greeter#39 · 1 comment ·
-
Difficulty 1/5 Under an hour Newbie friendliness 68/100
ilya-zlobintsev/LACT#1235 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
DayuanJiang/PecoFence#139 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
lyswhut/lx-music-desktop#3026 ·