Hacktoberfest 2026 : les issues que les mainteneurs ont marquées pour octobre, ouvertes et accessibles aux débutants. Parcourir les issues Hacktoberfest

BUG: BinAsciiConverter identifiers collide for different word-selection indices

Fermée
  • Quelque chose ne va pas ?
#2,995 2 commentaires 0 réactions 1 personne assignée Voir sur GitHub

Les mainteneurs répondent en général sous 2 jours

@LE0-Lin y travaille déjà.

Depuis le 9/10/2026.

  • #3000 par @LE0-Lin — ouverte

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
62/100
Type d'issue
Bug
Clarté
Plutôt claire
Activité
Active
Stack technique
python
Domaine
backend

Piste de recherche

Start with BinAsciiConverter._build_identifier() and compare its parameters with WordLevelConverter's use of get_identifier_params(); the issue links both files. Run the reproduction on current main, then add regression tests for distinct identifiers and successful registry registration for different indices. Confirm whether the default/all-words identifier remains unchanged, as the issue requests, and run the relevant converter and registry tests.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

Describe the bug

BinAsciiConverter instances using WordIndexSelectionStrategy(indices=[0]) and indices=[1] transform different words, but have identical identifier parameters, hashes, and default registry names. Registering both instances without custom names therefore raises a duplicate-name error.

I can reproduce this and would like to take the fix and submit regression tests. Could a maintainer confirm that this is available for me to work on and clarify whether the existing default/all-words identifier must remain unchanged?

This is related to the missing selection configuration reported for StringJoinConverter in #2973. The current #2976 changes only StringJoinConverter and its tests; this report concerns the separate BinAsciiConverter override. If the team prefers a coordinated broader fix, please advise on the scope before I prepare a PR.

Steps/Code to Reproduce

Run on current main at 34cab5c7626ac6e3359aba11526d534896935250. No model, database initialization, network requests, or external data are required.

import asyncio

from pyrit.converter import BinAsciiConverter, WordIndexSelectionStrategy
from pyrit.registry import ConverterRegistry


async def main():
    first = BinAsciiConverter(word_selection_strategy=WordIndexSelectionStrategy(indices=[0]))
    second = BinAsciiConverter(word_selection_strategy=WordIndexSelectionStrategy(indices=[1]))
    for converter in (first, second):
        result = await converter.convert_async(prompt="ab cd", input_type="text")
        print(result.output_text, converter.get_identifier().unique_name)
    print("Equal hashes:", first.get_identifier().hash == second.get_identifier().hash)
    registry = ConverterRegistry()
    registry.instances.register(first)
    registry.instances.register(second)


asyncio.run(main())
Expected Results

The outputs should be 6162 cd and ab 6364, respectively: the independent UTF-8 hex encodings of ab and cd are 6162 and 6364. These are different behavioral configurations, so their identifiers and default registry names should differ and both registrations should succeed.

ComponentIdentifier describes identity as a snapshot of behavioral configuration. WordLevelConverter already includes the selection strategy's get_identifier_params() in its identifier.

Actual Results

The conversion outputs are correct, but both configurations have the same identity:

6162 cd BinAsciiConverter::1b5f7f5d
ab 6364 BinAsciiConverter::1b5f7f5d
Equal hashes: True
ValueError: Instance 'BinAsciiConverter::1b5f7f5d' already exists

Both full hashes are 1b5f7f5de3b280c2738f825b231e04f593136480ebb4dccf15a1ef596dcfda76. Supplying separate custom registry names works around registration, but leaves the configuration hashes identical.

The BinAsciiConverter._build_identifier() override includes the selection strategy's class name, separator, and encoding function, but omits the strategy parameters such as indices. A focused fix would retain those behavior-bearing parameters while respecting the required compatibility of existing default identifiers.

No production code has been changed for this report.

Screenshots

Not applicable; the text output above is the reproduction result.

Versions

Windows 11, Python 3.12.0, PyRIT 1.2.0.dev0 from the source SHA above. pyrit.show_versions() reports:

System:
    python: 3.12.0 (tags/v3.12.0:0fb18b0, Oct  2 2023, 13:03:39) [MSC v.1935 64 bit (AMD64)]
executable: E:\OpenSource\ai-contribution-plan\venvs\pyrit\Scripts\python.exe
   machine: Windows-11-10.0.26100-SP0

Python dependencies:
        pyrit: 1.2.0.dev0
       Cython: None
        numpy: 2.5.3
       openai: 3.24.0
    packaging: 26.3
          pip: None
        scipy: 1.18.1
   setuptools: None
      sqlite3: None
        torch: None
 transformers: 5.18.0

AI assistance: Codex wrote this reproducer and report, executed the local reproduction, and assisted with code inspection and duplicate searches.

Langage dominant
Python
Étoiles
4.6k
Forks
944
Merge moyen
2 j 20 h
PR mergées (30 j)
309

Préparer son environnement

Ouvrir dans Codespaces

Lance le conteneur de développement du projet dans votre navigateur, avec votre propre compte GitHub.

  • Aucun Dockerfile ni fichier Docker Compose
  • Propose un modèle de pull request
  • Aucun guide de contribution

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de microsoft/PyRIT

Toutes les issues de microsoft/PyRIT

Issues similaires

Plus d'issues Python

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.