Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

BUG: BinAsciiConverter identifiers collide for different word-selection indices

Cerrado
  • ¿Algo no está bien?
#2,995 2 comentarios 0 reacciones 1 asignado Ver en GitHub

Los mantenedores suelen responder en 2 días

@LE0-Lin ya está trabajando en esto.

Desde el 9/10/2026.

  • #3000 de @LE0-Lin — abierto

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
62/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
python
Área
backend

Línea de trabajo

Start with BinAsciiConverter._build_identifier() and compare its parameters with WordLevelConverter's use of get_identifier_params(); the issue links both files. Run the reproduction on current main, then add regression tests for distinct identifiers and successful registry registration for different indices. Confirm whether the default/all-words identifier remains unchanged, as the issue requests, and run the relevant converter and registry tests.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Describe the bug

BinAsciiConverter instances using WordIndexSelectionStrategy(indices=[0]) and indices=[1] transform different words, but have identical identifier parameters, hashes, and default registry names. Registering both instances without custom names therefore raises a duplicate-name error.

I can reproduce this and would like to take the fix and submit regression tests. Could a maintainer confirm that this is available for me to work on and clarify whether the existing default/all-words identifier must remain unchanged?

This is related to the missing selection configuration reported for StringJoinConverter in #2973. The current #2976 changes only StringJoinConverter and its tests; this report concerns the separate BinAsciiConverter override. If the team prefers a coordinated broader fix, please advise on the scope before I prepare a PR.

Steps/Code to Reproduce

Run on current main at 34cab5c7626ac6e3359aba11526d534896935250. No model, database initialization, network requests, or external data are required.

import asyncio

from pyrit.converter import BinAsciiConverter, WordIndexSelectionStrategy
from pyrit.registry import ConverterRegistry


async def main():
    first = BinAsciiConverter(word_selection_strategy=WordIndexSelectionStrategy(indices=[0]))
    second = BinAsciiConverter(word_selection_strategy=WordIndexSelectionStrategy(indices=[1]))
    for converter in (first, second):
        result = await converter.convert_async(prompt="ab cd", input_type="text")
        print(result.output_text, converter.get_identifier().unique_name)
    print("Equal hashes:", first.get_identifier().hash == second.get_identifier().hash)
    registry = ConverterRegistry()
    registry.instances.register(first)
    registry.instances.register(second)


asyncio.run(main())
Expected Results

The outputs should be 6162 cd and ab 6364, respectively: the independent UTF-8 hex encodings of ab and cd are 6162 and 6364. These are different behavioral configurations, so their identifiers and default registry names should differ and both registrations should succeed.

ComponentIdentifier describes identity as a snapshot of behavioral configuration. WordLevelConverter already includes the selection strategy's get_identifier_params() in its identifier.

Actual Results

The conversion outputs are correct, but both configurations have the same identity:

6162 cd BinAsciiConverter::1b5f7f5d
ab 6364 BinAsciiConverter::1b5f7f5d
Equal hashes: True
ValueError: Instance 'BinAsciiConverter::1b5f7f5d' already exists

Both full hashes are 1b5f7f5de3b280c2738f825b231e04f593136480ebb4dccf15a1ef596dcfda76. Supplying separate custom registry names works around registration, but leaves the configuration hashes identical.

The BinAsciiConverter._build_identifier() override includes the selection strategy's class name, separator, and encoding function, but omits the strategy parameters such as indices. A focused fix would retain those behavior-bearing parameters while respecting the required compatibility of existing default identifiers.

No production code has been changed for this report.

Screenshots

Not applicable; the text output above is the reproduction result.

Versions

Windows 11, Python 3.12.0, PyRIT 1.2.0.dev0 from the source SHA above. pyrit.show_versions() reports:

System:
    python: 3.12.0 (tags/v3.12.0:0fb18b0, Oct  2 2023, 13:03:39) [MSC v.1935 64 bit (AMD64)]
executable: E:\OpenSource\ai-contribution-plan\venvs\pyrit\Scripts\python.exe
   machine: Windows-11-10.0.26100-SP0

Python dependencies:
        pyrit: 1.2.0.dev0
       Cython: None
        numpy: 2.5.3
       openai: 3.24.0
    packaging: 26.3
          pip: None
        scipy: 1.18.1
   setuptools: None
      sqlite3: None
        torch: None
 transformers: 5.18.0

AI assistance: Codex wrote this reproducer and report, executed the local reproduction, and assisted with code inspection and duplicate searches.

Lenguaje dominante
Python
Estrellas
4.6k
Forks
944
Merge medio
2 d 20 h
PR fusionados (30 d)
309

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

  • Sin Dockerfile ni archivo de Docker Compose
  • Tiene una plantilla de pull request
  • Sin guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de microsoft/PyRIT

Todos los issues de microsoft/PyRIT

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.