crt.sh is the only CT source; add a fallback

Ouverte
#416 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
55/100
Type d'issue
Fonctionnalité
Clarté
Plutôt claire
Activité
Active
Stack technique
go
Domaine
cli, networking

Piste de recherche

Read internal/passive/passive.go around Known and the ct source mapping, then inspect internal/ct/ct.go and internal/retryhttp. Check the proposed service's terms, unauthenticated quota, and pagination requirements before choosing its API. Add a selectable CT source with hermetic httptest coverage and document it in the passive-sources docs; verify it can be selected through -sources.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

enhancement severity: low

Summary

crt.sh is the only Certificate Transparency source. When it is overloaded or down, which is common for large domains, -ct contributes nothing to that run.

Where

  • internal/passive/passive.go:40-43 (var Known = []string{"ct", "wayback"})
  • internal/passive/passive.go:78-86 (ct maps to the crt.sh client only)

Details

Passive-source failures are reported per source, so a crt.sh outage simply leaves the CT seeds empty.

Impact

crt.sh often returns 5xx or times out on large domains. Scheduled Action monitoring then silently loses its CT-derived candidates for that run, while the run still succeeds.

Suggested fix

Add a second keyless CT source under its own name in Known, for example SSLMate Cert Spotter's issuances API, which has an unauthenticated tier with a small hourly quota. Optionally let ct fall back to it when crt.sh fails. Reuse internal/retryhttp and the existing size caps.

Open questions: the unauthenticated quota is small and large domains need pagination. Check the service's terms before adding it.

Acceptance criteria

  • A second CT source selectable through -sources
  • Hermetic tests against an httptest server
  • Documented in the passive-sources docs

Getting started

  • Relevant files: internal/passive/passive.go, internal/ct/ct.go, internal/retryhttp

Filed by repo-audit/full-audit at dd5b156. Severity: low. Effort: M. audit-key: enhancement|internal/passive/passive.go|Known

Langage dominant
Go
Étoiles
1
Forks
1
Merge moyen
8 h 3 min
PR mergées (30 j)
31

Préparer son environnement

Ouvrir dans Codespaces

Lance le conteneur de développement du projet dans votre navigateur, avec votre propre compte GitHub.

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de TMHSDigital/subenum

Toutes les issues de TMHSDigital/subenum

Issues similaires

Plus d'issues Go

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.