crt.sh is the only CT source; add a fallback

未關閉
#416 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
4/5
預估耗時
3-5 天
新手友好度
55/100
Issue 類型
功能
描述清晰度
基本清楚
活躍度
活躍
技術堆疊
go
領域
cli, networking

研究方向

Read internal/passive/passive.go around Known and the ct source mapping, then inspect internal/ct/ct.go and internal/retryhttp. Check the proposed service's terms, unauthenticated quota, and pagination requirements before choosing its API. Add a selectable CT source with hermetic httptest coverage and document it in the passive-sources docs; verify it can be selected through -sources.

由索引模型根據 Issue 內容生成。

描述

enhancement severity: low

Summary

crt.sh is the only Certificate Transparency source. When it is overloaded or down, which is common for large domains, -ct contributes nothing to that run.

Where

  • internal/passive/passive.go:40-43 (var Known = []string{"ct", "wayback"})
  • internal/passive/passive.go:78-86 (ct maps to the crt.sh client only)

Details

Passive-source failures are reported per source, so a crt.sh outage simply leaves the CT seeds empty.

Impact

crt.sh often returns 5xx or times out on large domains. Scheduled Action monitoring then silently loses its CT-derived candidates for that run, while the run still succeeds.

Suggested fix

Add a second keyless CT source under its own name in Known, for example SSLMate Cert Spotter's issuances API, which has an unauthenticated tier with a small hourly quota. Optionally let ct fall back to it when crt.sh fails. Reuse internal/retryhttp and the existing size caps.

Open questions: the unauthenticated quota is small and large domains need pagination. Check the service's terms before adding it.

Acceptance criteria

  • A second CT source selectable through -sources
  • Hermetic tests against an httptest server
  • Documented in the passive-sources docs

Getting started

  • Relevant files: internal/passive/passive.go, internal/ct/ct.go, internal/retryhttp

Filed by repo-audit/full-audit at dd5b156. Severity: low. Effort: M. audit-key: enhancement|internal/passive/passive.go|Known

主要語言
Go
星號
1
分支
1
平均合併
8 小時 3 分鐘
30 天內合併 PR
31

環境準備

在 Codespaces 中開啟

在瀏覽器裡用你自己的 GitHub 帳號啟動這個專案的開發容器。

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

TMHSDigital/subenum 的其他 Issue

查看 TMHSDigital/subenum 的全部 Issue

相似的 Issue

更多 Go Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。