Set per-monitor DPI awareness explicitly and verify picks on mixed-DPI desktops

Ouverte
#67 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 3 jours

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
35/100
Type d'issue
Fonctionnalité
Clarté
Plutôt claire
Activité
Calme
Stack technique
python

Piste de recherche

Start with the entry point that defines main(), autoclicker/gui/picker.py, and click_engine.py; inspect WindowsAutoclicker.spec and the DPI notes in docs/ARCHITECTURE.md and docs/PERFORMANCE.md. Verify the awareness call runs before Tk and PyAutoGUI load, then use the proposed unit test and manually check picked clicks on both monitors of a mixed-DPI Windows desktop. Done means per-monitor awareness is documented and each click lands on its picked pixel.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

bug maintenance priority: low

Why it matters

Picking and clicking only line up if the picker (Tk) and the clicker (PyAutoGUI / Win32) agree on what a pixel is. Today the process's DPI awareness is set implicitly, as a side effect of importing PyAutoGUI, and only to system awareness. On the setups where coordinate bugs actually happen (a 4K laptop at 150% next to a 1080p monitor at 100%), Windows virtualizes coordinates per monitor for system-aware apps. The result may be fine, slightly off, or a blurry overlay on one screen, and nothing in the repo verifies which.

Evidence

  • pyautogui/_pyautogui_win.py calls ctypes.windll.user32.SetProcessDPIAware() at import (system-aware, not per-monitor).
  • No SetProcessDpiAwarenessContext call and no manifest entry in WindowsAutoclicker.spec; nothing in autoclicker/ mentions DPI.
  • autoclicker/gui/picker.py sizes the overlay from GetSystemMetrics(SM_*VIRTUALSCREEN) and reports event.x_root/y_root; click_engine.py moves with pyautogui.moveTo. Correctness on mixed-DPI desktops depends on both sides being virtualized identically.
  • docs/PERFORMANCE.md and docs/ARCHITECTURE.md already list "multi-monitor DPI risk" as a reason to defer a SendInput path.

Suggested approach

  1. Set awareness explicitly and first thing in main() (before Tk and PyAutoGUI load): SetProcessDpiAwarenessContext(DPI_AWARENESS_CONTEXT_PER_MONITOR_AWARE_V2) with fallbacks to SetProcessDpiAwareness(2) and SetProcessDPIAware(). Optionally also embed it in the exe manifest.
  2. Manually verify on a mixed-DPI two-monitor setup: pick a point on each monitor, run, and confirm the click lands on the picked pixel. Record the result in docs/ARCHITECTURE.md.
  3. Add a unit test that main() calls the awareness setter before creating the app.

Done when

  • DPI awareness is explicit, per-monitor v2 where available, and documented.
  • Picks on every monitor of a mixed-DPI desktop click the exact picked pixel (verified once manually and noted in docs).
Langage dominant
Python
Étoiles
0
Forks
2
Merge moyen
2 j 13 h
PR mergées (30 j)
2

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de TMHSDigital/autoclicker

Toutes les issues de TMHSDigital/autoclicker

Issues similaires

Plus d'issues Python

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.