Wait step that clicks an image can pause a run with Pause when unfocused

Ouverte
#201 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 3 jours

Personne n'a encore pris cette issue.

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
52/100
Type d'issue
Bug
Clarté
Plutôt claire
Activité
Active
Stack technique
python
Domaine
desktop

Piste de recherche

Start in autoclicker/core/click_engine.py, reading _windows_under_steps to see how the allowed windows are built from click and hold points, then _perform_sequence to find where a wait-image step clicks its match. The issue suggests adding the root window under the clicked point to _step_hwnds for the rest of the run. Done means a test like TestSequenceFocus.test_any_step_window_counts_as_in_front passes, where the clicked image sits in a window no step point covers and the run keeps going.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

bug priority: low

Summary

With Pause when unfocused on, a sequence's allowed windows are the ones under its click and hold points. A wait_image step with "click the image" set clicks wherever the image is found, so a window that appears only there is not in that set. If that click brings it to the front, the run pauses at the next step.

Where

  • autoclicker/core/click_engine.py (_windows_under_steps, _perform_sequence)

Steps to reproduce

  1. Sequence: click a button in window A that opens window B, then a wait-for-image step on a button in B with click on, then another step.
  2. Turn on Pause when unfocused and start.
  3. After the image click, B is in front and the run pauses ("waiting for the target window to be in front").

Suggested fix

After a wait step clicks its match, add the root window under that point (if it isn't ours) to _step_hwnds for the rest of the run, the same way windows under step points are added at Start.

Acceptance criteria

  • A test like TestSequenceFocus.test_any_step_window_counts_as_in_front where the clicked image is in a window no step point covers, and the run keeps going

Related: #119

Langage dominant
Python
Étoiles
0
Forks
2
Merge moyen
2 j 13 h
PR mergées (30 j)
2

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de TMHSDigital/autoclicker

Toutes les issues de TMHSDigital/autoclicker

Issues similaires

Plus d'issues Python

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.